-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust responsiveness of workflow run tasks tabe #1221
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Improve responsiveness of workflow run tasks table and handle failure reasons for canceled tasks in `WorkflowBlockCollapsibleContent.tsx` and `WorkflowRun.tsx`. > > - **Responsiveness Adjustments**: > - Adjust column widths in `WorkflowBlockCollapsibleContent.tsx` and `WorkflowRun.tsx` for better responsiveness. > - Add `truncate` class to table cells in `WorkflowBlockCollapsibleContent.tsx` to handle long text. > - **Failure Reason Handling**: > - Display failure reason for canceled tasks in `WorkflowBlockCollapsibleContent.tsx` by checking `Status.Canceled`. > - **Misc**: > - Add `title` attribute to table cells in `WorkflowBlockCollapsibleContent.tsx` for better accessibility. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 6514fde17d3636c80d35deecf98736a9786bde18. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on bbbca2a in 11 seconds
More details
- Looked at
151
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowBlockCollapsibleContent.tsx:102
- Draft comment:
Consider adding atitle
attribute to thisTableCell
for better accessibility, similar to other cells. This will help users understand the content on hover. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding atitle
attribute for better accessibility, but it seems to be missing in some places.
2. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:553
- Draft comment:
Consider adding atitle
attribute to thisTableHead
for better accessibility, similar to other headers. This will help users understand the content on hover. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding atitle
attribute for better accessibility, but it seems to be missing in some places.
Workflow ID: wflow_7Db57e3dB8NGXML0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to bbbca2a in 14 seconds
More details
- Looked at
151
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowBlockCollapsibleContent.tsx:102
- Draft comment:
Consider adding atitle
attribute to thisTableCell
for better accessibility, similar to other cells. This will help users understand the content on hover. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding atitle
attribute for better accessibility, but it seems to be missing in some places.
2. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:552
- Draft comment:
Consider adding atitle
attribute to thisTableHead
for better accessibility, similar to other headers. This will help users understand the content on hover. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding atitle
attribute for better accessibility, but it seems to be missing in some places.
3. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:553
- Draft comment:
Consider adding atitle
attribute to thisTableHead
for better accessibility, similar to other headers. This will help users understand the content on hover. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding atitle
attribute for better accessibility, but it seems to be missing in some places.
Workflow ID: wflow_FCXxTCbcknfdTqXP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Improve responsiveness of workflow run tasks table and handle failure reasons for canceled tasks in
WorkflowBlockCollapsibleContent.tsx
andWorkflowRun.tsx
.WorkflowBlockCollapsibleContent.tsx
andWorkflowRun.tsx
for better responsiveness.truncate
class to table cells inWorkflowBlockCollapsibleContent.tsx
to handle long text.WorkflowBlockCollapsibleContent.tsx
by checkingStatus.Canceled
.title
attribute to table cells inWorkflowBlockCollapsibleContent.tsx
for better accessibility.TaskListSkeletonRows
with a new skeleton loader inWorkflowRun.tsx
.This description was created by for bbbca2a. It will automatically update as commits are pushed.