Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new workflow block #1228

Merged
merged 1 commit into from
Nov 21, 2024
Merged

add new workflow block #1228

merged 1 commit into from
Nov 21, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 21, 2024

Important

This PR adds new workflow blocks ValidationBlock and ActionBlock, updates the database schema for task criteria and prompt templates, and introduces new prompt templates for task actions.

  • Database Schema:
    • Adds columns prompt_template, complete_criterion, and terminate_criterion to tasks table in 2024_11_21_0708-2d79d5fc1baa_add_task_prompt_template_complete_.py.
  • Workflow Blocks:
    • Introduces ValidationBlock and ActionBlock in block.py with specific execution logic.
    • Updates block_yaml_to_block() in service.py to handle new block types.
  • Prompt Templates:
    • Adds new templates decisive-criterion-validate.j2, single-click-action.j2, single-input-action.j2, single-select-action.j2, and single-upload-action.j2 for different task actions.
  • Enums and Models:
    • Adds TaskPromptTemplate and ActionType enums in enums.py.
    • Updates TaskModel in models.py to include new fields for task criteria and prompt templates.
  • Misc:
    • Modifies create_task() in client.py to include new task fields.
    • Updates convert_to_task() in utils.py to handle new task attributes.

This description was created by Ellipsis for e8f7db0. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to e8f7db0 in 1 minute and 32 seconds

More details
  • Looked at 856 lines of code in 16 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. alembic/versions/2024_11_21_0708-2d79d5fc1baa_add_task_prompt_template_complete_.py:23
  • Draft comment:
    Consider specifying a length for the new String columns (e.g., sa.String(255)) to ensure consistency and avoid potential issues with data storage.
  • Reason this comment was not posted:
    Marked as duplicate.
2. skyvern/forge/sdk/db/models.py:61
  • Draft comment:
    Consider specifying a length for the String column 'complete_criterion' to ensure consistency and avoid potential issues with data storage. This comment also applies to 'prompt_template' and 'terminate_criterion' columns.
  • Reason this comment was not posted:
    Marked as duplicate.
3. skyvern/forge/sdk/db/models.py:62
  • Draft comment:
    Consider specifying a length for the String column 'terminate_criterion' to ensure consistency and avoid potential issues with data storage. This comment also applies to 'prompt_template' and 'complete_criterion' columns.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_gqt90VoloaNPLqVD


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

skyvern/forge/sdk/db/models.py Show resolved Hide resolved
@LawyZheng LawyZheng merged commit 3f20940 into main Nov 21, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/add-new-workflow-block branch November 21, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant