Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use orignal action type #1229

Merged
merged 1 commit into from
Nov 21, 2024
Merged

use orignal action type #1229

merged 1 commit into from
Nov 21, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 21, 2024

Important

Change ActionType source to skyvern.webeye.actions.actions and update references in yaml.py and service.py.

  • Imports:
    • Change ActionType import source from skyvern.forge.sdk.db.enums to skyvern.webeye.actions.actions in yaml.py and service.py.
  • Enums:
    • Remove ActionType class from enums.py.
  • Functions:
    • Update block_yaml_to_block in service.py to use ActionType from skyvern.webeye.actions.actions.

This description was created by Ellipsis for bd404e0. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bd404e0 in 37 seconds

More details
  • Looked at 72 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:1369
  • Draft comment:
    The prompt_template variable is initialized but not used if block_yaml.action_type does not match any of the ActionType cases. Consider adding a default case or handling the scenario where prompt_template remains an empty string.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_iXLuEsocRPri86ms


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 7e5f5d6 into main Nov 21, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/use-original-action-type branch November 21, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant