move action type validate in workflow runtime

[LawyZheng]

Important

Move action type validation from service.py to ActionBlock in block.py, centralizing logic and improving modularity.

• Behavior:
  • Move action type validation logic from block_yaml_to_block() in service.py to execute() in ActionBlock in block.py.
  • ActionBlock now determines prompt_template based on ActionType and handles unsupported actions by raising an exception.
  • If LLM_API_HANDLER returns an error, ActionBlock raises FailedToParseActionInstruction.
• Imports:
  • Add FailedToParseActionInstruction and ActionType imports to block.py.
  • Remove FailedToParseActionInstruction and ActionType imports from service.py.

^{This description was created by for a883a2a. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to a883a2a in 40 seconds

More details

• Looked at 123 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern/forge/sdk/workflow/models/block.py:1303

• Draft comment:
  Consider logging the action_type after it is determined. This can help in debugging and understanding the flow of execution.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR moves the action type validation logic from block_yaml_to_block in service.py to the execute method in block.py. This change is reflected in the removal of the validation logic from block_yaml_to_block. The logic is now encapsulated within the ActionBlock class, which is a more appropriate location for this functionality, as it pertains specifically to the execution of an action block.

2. skyvern/forge/sdk/workflow/models/block.py:1326

• Draft comment:
  The exception message here is hardcoded. Consider defining a constant or using a configuration file for such messages to maintain consistency and ease of updates across the codebase.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR moves the action type validation logic from block_yaml_to_block in service.py to the execute method in block.py. This change is reflected in the removal of the validation logic from block_yaml_to_block. The logic is now encapsulated within the ActionBlock class, which is a more appropriate location for this functionality, as it pertains specifically to the execution of an action block.

3. skyvern/forge/sdk/workflow/service.py:1372

• Draft comment:
  The prompt_template assignment has been removed from here and moved to the ActionBlock class. Ensure that this change does not affect any other logic that might depend on prompt_template being set at this point.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR moves the action type validation logic from block_yaml_to_block in service.py to the execute method in block.py. This change is reflected in the removal of the validation logic from block_yaml_to_block. The logic is now encapsulated within the ActionBlock class, which is a more appropriate location for this functionality, as it pertains specifically to the execution of an action block.

Workflow ID: wflow_kwX9nP1LAL92mumH

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.