Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add navigation, login, extraction workflow blocks #1238

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 22, 2024

Important

Add NavigationBlock, ExtractionBlock, and LoginBlock to workflow models, YAML definitions, and service logic.

  • Models:
    • Add NavigationBlock, ExtractionBlock, and LoginBlock classes in block.py.
    • Extend BlockType enum with NAVIGATION, EXTRACTION, and LOGIN.
    • Update BlockSubclasses union to include new block classes.
  • YAML Definitions:
    • Add NavigationBlockYAML, ExtractionBlockYAML, and LoginBlockYAML classes in yaml.py.
    • Update BLOCK_YAML_SUBCLASSES to include new YAML block classes.
  • Service Logic:
    • Update block_yaml_to_block() in service.py to handle new block types.
    • Add logic to convert YAML definitions to block instances for NavigationBlock, ExtractionBlock, and LoginBlock.

This description was created by Ellipsis for c9345b3. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to c9345b3 in 48 seconds

More details
  • Looked at 197 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_50wgBOUAMUbqg67w


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

skyvern/forge/sdk/workflow/models/block.py Show resolved Hide resolved
@LawyZheng LawyZheng merged commit 3eb9d13 into main Nov 22, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/add-more-workflow-blocks branch November 22, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant