Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show workflow outputs in workflow run screen #1239

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 22, 2024

Important

Add UI section in WorkflowRun.tsx to display workflow outputs in JSON format when run is finalized.

  • UI Enhancement:
    • In WorkflowRun.tsx, added a section to display "Block Outputs" using CodeEditor when workflowRunIsFinalized is true.
    • Outputs are shown in JSON format, read-only, with a min height of 96px and max height of 500px.

This description was created by Ellipsis for a0936bd. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Add UI section to display workflow outputs in JSON format when workflow run is finalized in `WorkflowRun.tsx`.
>
>   - **UI Enhancement**:
>     - In `WorkflowRun.tsx`, added a section to display "Block Outputs" using `CodeEditor` when `workflowRunIsFinalized` is true.
>     - Outputs are shown in JSON format, read-only, with a min height of 96px and max height of 500px.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 6f42ae3f4714fb0988c0fd123a941f3936916ea7. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on a0936bd in 9 seconds

More details
  • Looked at 25 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:621
  • Draft comment:
    Consider adding a null check for workflowRun.outputs before using JSON.stringify to avoid potential errors if outputs is undefined.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces a new UI section to display workflow outputs in JSON format when the workflow run is finalized. The implementation seems correct, but there are a few areas to improve.

Workflow ID: wflow_1BKdoL2O2tEeI8t1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a0936bd in 36 seconds

More details
  • Looked at 25 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:621
  • Draft comment:
    Consider checking if workflowRun.outputs is defined before using JSON.stringify to avoid potential errors.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is suggesting a potential improvement to avoid runtime errors if workflowRun.outputs is undefined. However, the code already checks if workflowRun is truthy, which reduces the likelihood of workflowRun.outputs being undefined. The comment is speculative and not based on a definite issue, as the code logic seems to handle the case where workflowRun is undefined.
    The comment might be valid if workflowRun.outputs can be undefined even when workflowRun is truthy. However, without evidence of this scenario, the comment remains speculative.
    The comment lacks strong evidence of a definite issue, as the code logic already checks for workflowRun. Without further context or evidence, the comment seems speculative.
    The comment is speculative and not based on a definite issue. It should be deleted as it does not provide strong evidence of a necessary code change.

Workflow ID: wflow_iV0XQIK8VNzD3GBl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit cec2ad3 into main Nov 22, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/show-outputs-in-workflow-run-screen branch November 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants