cleanup_element_tree_factory compatibility without task/step #1252
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 108fd5d in 19 seconds
More details
- Looked at
185lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/scraper/domUtils.js:254
- Draft comment:
Ensureelement.classNameis not null or undefined before callingtoString()to prevent potential runtime errors. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_pQ6svyOhFZcwFPcP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 108fd5d in 18 seconds
More details
- Looked at
185lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/scraper/domUtils.js:254
- Draft comment:
Ensureelement.classNameis not null or undefined before callingtoString()to prevent runtime errors. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_l69zD0I4PiopHUoG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
wintonzheng
changed the title
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Adds `run_observer` function for handling user prompts and workflow creation, updates agent functions for optional task/step parameters, and introduces new prompt templates. > > - **New Functionality**: > - Adds `run_observer()` in `scripts/run_observer.py`, an async function to handle user prompts and create workflows. > - Uses `generate_navigation_url.j2` and `observer.j2` templates for prompt generation. > - **Agent Functions**: > - Modifies `_convert_svg_to_string()` and `_convert_css_shape_to_string()` in `agent_functions.py` to make `task` and `step` parameters optional. > - Updates `cleanup_element_tree_factory()` to use modified conversion functions. > - **Prompts**: > - Adds `generate_navigation_url.j2` for URL generation based on user goals. > - Adds `observer.j2` for planning tasks based on DOM elements and user goals. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for a4b308e8b91551a4a08a40b84ace74cd2e90259b. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
wintonzheng
force-pushed
the
shu/observer
branch
from
108fd5d to
512fc34
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 512fc34 in 27 seconds
More details
- Looked at
171lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent_functions.py:110
- Draft comment:
Consider checking iftaskandstepare notNonebefore loggingtask_idandstep_idto avoid unnecessary log entries withNonevalues. This applies to all logging statements usingtask_idandstep_id. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_Osn265XlhVrh8htF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
why do we need this change? without step, we can't record any artifacts |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on dc83954 in 28 seconds
More details
- Looked at
37lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent.py:1123
- Draft comment:
Consider makingtaskandstepoptional parameters in_scrape_with_typeto align with the PR's intent of making them optional in agent functions. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_9XBZYMv3dOaxt7IB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
wintonzheng
force-pushed
the
shu/observer
branch
from
dc83954 to
face022
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on face022 in 24 seconds
More details
- Looked at
45lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent.py:1122
- Draft comment:
Thetaskandstepparameters are still mandatory in_scrape_with_typeand_build_and_record_step_prompt. Consider making them optional if that aligns with the PR's intent. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_4T8int4PjZEg5ZhV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Adds
run_observerfunction, makestaskandstepoptional in agent functions, and introduces new prompt templates.run_observer()inscripts/run_observer.py, an async function to handle user prompts and create workflows.generate_navigation_url.j2andobserver.j2templates for prompt generation._convert_svg_to_string()and_convert_css_shape_to_string()inagent_functions.pyto maketaskandstepparameters optional.cleanup_element_tree_factory()to use modified conversion functions.generate_navigation_url.j2for URL generation based on user goals.observer.j2for planning tasks based on DOM elements and user goals.organizationparameter from_scrape_with_type()and_build_and_record_step_prompt()inagent.py.This description was created by
for face022. It will automatically update as commits are pushed.