Enforce navigation_goal in NavigationBlock and data_extraction_goal in ExtractionBlock #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Introduces `ExtractionBlock` for data extraction tasks in workflows, updating models, prompts, and observer handling. > > - **Behavior**: > - Introduces `ExtractionBlock` to handle data extraction tasks in workflows. > - Updates `run_observer.py` to handle `extraction` task type, generating and executing extraction tasks. > - Adds prompt template `generate_extraction_task.j2` for extraction task generation. > - **Models**: > - Adds `ExtractionBlock` and `ExtractionBlockYAML` classes in `block.py` and `yaml.py`. > - Updates `WorkflowService` to create output parameters for `ExtractionBlock`. > - **Misc**: > - Renames `task` options in `observer.j2` from `navigate` to `navigation` and `extract` to `extraction`. > - Updates `agent.py` to handle `data_extraction_goal` in task creation. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 4d13dfbca2b5aac2bd53c190cb7171f522682ef7. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
wintonzheng
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 734b3cd in 31 seconds
More details
- Looked at
58lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:1210
- Draft comment:
The methodcreate_output_parameter_for_blockis still marked as@staticmethod. Consider removing the static method decorator if this method is intended to be an instance method. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_e3o8f7GW6uUzN8Uk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 734b3cd in 39 seconds
More details
- Looked at
58lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:1210
- Draft comment:
The methodcreate_output_parameter_for_blockis still marked as@staticmethod. Consider removing the static method decorator if the method is intended to be an instance method. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_s5xBxQJmRUh35m9x
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduces
ExtractionBlockfor data extraction tasks in workflows, updating models, prompts, and observer handling.ExtractionBlockto handle data extraction tasks in workflows.run_observer.pyto handleextractiontask type, generating and executing extraction tasks.generate_extraction_task.j2for extraction task generation.ExtractionBlockandExtractionBlockYAMLclasses inblock.pyandyaml.py.WorkflowServiceto create output parameters forExtractionBlock.taskoptions inobserver.j2fromnavigatetonavigationandextracttoextraction.agent.pyto handledata_extraction_goalin task creation.This description was created by
for 734b3cd. It will automatically update as commits are pushed.