Fix tooltip weird behavior in editable titles #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Refactor `EditableNodeTitle` to fix tooltip behavior by separating editing and non-editing rendering logic. > > - **Behavior**: > - Refactor `EditableNodeTitle` in `EditableNodeTitle.tsx` to separate rendering logic for editing and non-editing states. > - Tooltip is only rendered when `editing` is `false`, fixing weird behavior during title editing. > - **Components**: > - Uses `TooltipProvider`, `Tooltip`, `TooltipTrigger`, and `TooltipContent` for non-editing state. > - Uses `HorizontallyResizingInput` for editing state. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 1d0a5fb8b2b4d5bafb206b639ba253e901a47ded. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7101faa in 23 seconds
More details
- Looked at
100lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx:28
- Draft comment:
The refactoring separates the editing and non-editing states, which is a good practice for clarity and maintainability. However, theTooltipProviderandTooltipcomponents are not necessary wheneditingis true, and the current implementation correctly avoids rendering them in that state. - Reason this comment was not posted:
Confidence changes required:10%
The refactoring separates the editing and non-editing states, which is a good practice for clarity and maintainability. However, theTooltipProviderandTooltipcomponents are not necessary wheneditingis true, and the current implementation correctly avoids rendering them in that state.
Workflow ID: wflow_7Fb3VJe3FxSRoEnH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7101faa in 28 seconds
More details
- Looked at
100lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx:28
- Draft comment:
Good separation of editing and non-editing states for clarity and maintainability. - Reason this comment was not posted:
Confidence changes required:0%
The refactoring separates the editing and non-editing states, which is a good practice for clarity and maintainability.
2. skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx:54
- Draft comment:
Ensure that the onBlur and onKeyDown handlers are efficient and correctly handle all edge cases. - Reason this comment was not posted:
Confidence changes required:33%
The onBlur and onKeyDown handlers are well-implemented, but it's important to ensure that the logic is correct and efficient.
Workflow ID: wflow_J2ZR1VulBq99O1TF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Refactor
EditableNodeTitleto fix tooltip behavior by separating editing and non-editing rendering logic.EditableNodeTitleinEditableNodeTitle.tsxto separate rendering logic for editing and non-editing states.editingisfalse, fixing weird behavior during title editing.TooltipProvider,Tooltip,TooltipTrigger, andTooltipContentfor non-editing state.HorizontallyResizingInputfor editing state.This description was created by
for 7101faa. It will automatically update as commits are pushed.