Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty llm_key promblem for the TextPromptBlock #1282

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 28, 2024

Important

Fixes empty llm_key issue in TextPromptBlock.send_prompt() by using a default key.

  • Behavior:
    • In TextPromptBlock.send_prompt(), use DEFAULT_TEXT_PROMPT_LLM_KEY if self.llm_key is empty.
  • Misc:
    • No other changes or refactors were made.

This description was created by Ellipsis for 37024eb. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 37024eb in 9 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:786
  • Draft comment:
    Using a default LLM key when self.llm_key is not set is a good practice to prevent errors due to missing keys.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR ensures that a default LLM key is used if self.llm_key is not set. This is a good practice to avoid potential errors due to missing keys.

Workflow ID: wflow_ee0WaeEFFCACQzUN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit f01a7aa into main Nov 28, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/fix_llm_key_empty_problem branch November 28, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant