fix loopblock continue on failure issue

[LawyZheng]

Important

Fixes ForLoopBlock continue on failure issue by introducing LoopBlockExecutedResult and refactoring execution logic in block.py.

• Behavior:
  • Fixes issue in ForLoopBlock where loop did not continue on failure.
  • Introduces LoopBlockExecutedResult to manage loop execution results, including outputs, block statuses, and failure reasons.
  • Refactors execute method in ForLoopBlock to use execute_loop_helper for better handling of block execution statuses.
• Classes and Methods:
  • Adds LoopBlockExecutedResult class to encapsulate loop execution results.
  • Refactors execute method in ForLoopBlock to utilize execute_loop_helper for improved logic separation and clarity.
• Misc:
  • Adds from __future__ import annotations for forward reference support.

^{This description was created by for 54657ce. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 54657ce in 1 minute and 10 seconds

More details

• Looked at 246 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern/forge/sdk/workflow/models/block.py:646

• Draft comment:
  The variable original_loop_block is assigned but never used. Consider removing it to simplify the code.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The variable original_loop_block is assigned but never used. It seems unnecessary to copy the loop block and then reassign it back to the original. This can be simplified.

2. skyvern/forge/sdk/workflow/models/block.py:752

• Draft comment:
  The final else clause is redundant since block_status is already set to BlockStatus.failed. Consider removing it for clarity.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The variable block_status is initially set to BlockStatus.failed and then conditionally reassigned. The final else clause is redundant since block_status is already set to BlockStatus.failed.

3. skyvern/forge/sdk/workflow/models/block.py:743

• Draft comment:
  The final else clause is redundant since success is already set to False. Consider removing it for clarity.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The variable success is initially set to False and then conditionally reassigned. The final else clause is redundant since success is already set to False.

Workflow ID: wflow_vijeXRHPfxHzVfXq

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.