Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust cache expiration policy #1284

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 28, 2024

Important

Adjust cache expiration policy by removing unnecessary refreshes and adding cache keys to log messages in agent_functions.py and local.py.

  • Cache Expiration:
    • Removed cache expiration refresh in get() method of LocalCache in local.py.
    • Added cache expiration refresh after successful SVG and CSS shape conversions in _convert_svg_to_string() and _convert_css_shape_to_string() in agent_functions.py.
  • Logging:
    • Added key to log messages in _convert_svg_to_string() and _convert_css_shape_to_string() in agent_functions.py for better traceability.

This description was created by Ellipsis for 528c9e7. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 528c9e7 in 14 seconds

More details
  • Looked at 125 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/cache/local.py:16
  • Draft comment:
    Removing await self.set(key, value) is correct. It was unnecessarily resetting cache expiration on access, which is not typical cache behavior.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_vYmLgoLzAAfrv2P3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit c4338e9 into main Nov 28, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/adjust-cache-expiration-policy branch November 28, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant