Fix a bug where empty webhook url causes an issue #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Fixes validation issue in `RunWorkflowForm.tsx` for empty `webhookCallbackUrl` by checking for both `null` and empty strings. > > - **Bug Fix**: > - Fixes issue in `RunWorkflowForm.tsx` where an empty `webhookCallbackUrl` caused validation issues by updating the validation rule to check for both `null` and empty string values. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 1278c841938be07ae64edcf61bc80388c6fee8b2. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on eeb841c in 11 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:257
- Draft comment:
Consider returning a specific error message whenwebhookCallbackUrlis null or an empty string, similar to other validation rules. - Reason this comment was not posted:
Confidence changes required:50%
The validation logic forwebhookCallbackUrlshould return a specific error message when the value is null or an empty string, to maintain consistency with other validation rules.
Workflow ID: wflow_WGvHBRBtdBkFFhon
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to eeb841c in 40 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_IuZtGYuUGBpx4M8w
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -253,7 +253,7 @@ function RunWorkflowForm({ | |||
| name="webhookCallbackUrl" | |||
| rules={{ | |||
| validate: (value) => { | |||
| if (value === null) { | |||
| if (value === null || value === "") { | |||
| return; | |||
There was a problem hiding this comment.
Consider returning a specific error message when the value is null or an empty string to maintain consistency with other validation rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes validation issue in
RunWorkflowForm.tsxforwebhookCallbackUrlby checking for bothnulland empty strings.RunWorkflowForm.tsxforwebhookCallbackUrlby checking for bothnulland empty strings.This description was created by
for eeb841c. It will automatically update as commits are pushed.