all blocks support jinja template #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ee816e1 in 1 minute and 14 seconds
More details
- Looked at
285lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_8qpD3wBz65jybILo
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| if not potential_template: | ||
| return potential_template | ||
| template = Template(potential_template) | ||
| return template.render(workflow_run_context.values) |
There was a problem hiding this comment.
Consider adding exception handling for template rendering to handle cases where the template is invalid or context keys are missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds Jinja template support for block parameters in
block.py, enabling dynamic rendering using workflow context.format_block_parameter_template_from_workflow_run_context()to format block parameters using Jinja templates.format_potential_template_parameters()to dynamically render parameters inBaseTaskBlock,CodeBlock,TextPromptBlock,DownloadToS3Block,UploadToS3Block,SendEmailBlock,FileParserBlock, andForLoopBlock.format_potential_template_parameters()now formats parameters likelabel,title,url,totp_identifier,navigation_goal,data_extraction_goal,complete_criterion,terminate_criterion,code,llm_key,prompt,sender,subject,body,file_url, andpathusing Jinja templates.format_task_block_parameter_template_from_workflow_run_context()method.This description was created by
for ee816e1. It will automatically update as commits are pushed.