adjust s3 prefix for downloaded files #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3f95cba in 1 minute and 19 seconds
More details
- Looked at
62lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/config.py:55
- Draft comment:
Ensure that removingAWS_S3_BUCKET_DOWNLOADSdoes not affect other parts of the codebase that might rely on it. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_pFrL5fgJF07NGlg1
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| object_keys = await self.async_client.list_files(uri=uri) | ||
| if len(object_keys) == 0: | ||
| return [] | ||
| object_uris: list[str] = [] | ||
| for key in object_keys: | ||
| object_uri = f"s3://{settings.AWS_S3_BUCKET_DOWNLOADS}/{key}" | ||
| object_uri = f"s3://{settings.AWS_S3_BUCKET_UPLOADS}/{key}" |
There was a problem hiding this comment.
Include DOWNLOAD_FILE_PREFIX in the object_uri construction to maintain consistency with the new S3 path structure.
Suggested change
| object_uri = f"s3://{settings.AWS_S3_BUCKET_UPLOADS}/{key}" | |
| object_uri = f"s3://{settings.AWS_S3_BUCKET_UPLOADS}/{DOWNLOAD_FILE_PREFIX}/{key}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adjusts S3 prefix for downloaded files to use
AWS_S3_BUCKET_UPLOADSwithDOWNLOAD_FILE_PREFIXins3.py.save_downloaded_filesandget_downloaded_filesins3.pyto useAWS_S3_BUCKET_UPLOADSwithDOWNLOAD_FILE_PREFIX.AWS_S3_BUCKET_DOWNLOADSfromconfig.py.DOWNLOAD_FILE_PREFIXinconstants.pyset to "downloads".This description was created by
for 3f95cba. It will automatically update as commits are pushed.