Add URL to action block #1292
Merged
Add URL to action block #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Adds a URL input field to `ActionNode` in `ActionNode.tsx`, allowing users to specify a navigation URL with an explanatory tooltip. > > - **Behavior**: > - Adds a URL input field to `ActionNode` in `ActionNode.tsx`. > - URL field is editable and updates node data via `handleChange()`. > - Tooltip added for URL field explaining its purpose. > - **UI**: > - Adds `AutoResizingTextarea` for URL input with placeholder from `commonFieldPlaceholders`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b188fc9398adbd9bfe94da821dde96b2cf02811f. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 562a947 in 27 seconds
More details
- Looked at
80lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_ZNCBg52MtMvp4zjk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 562a947 in 1 minute and 27 seconds
More details
- Looked at
80lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx:99
- Draft comment:
Consider adding a type check forvalueinhandleChangeto ensure it matches the expected type for each key, preventing potential runtime errors. - Reason this comment was not posted:
Confidence changes required:50%
ThehandleChangefunction is used multiple times to update state and node data. It is important to ensure that theeditablecheck is consistently applied to prevent unintended updates when the node is not editable.
Workflow ID: wflow_jTl67OFc8dF0ekFU
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -26,6 +26,8 @@ import { | |||
| commonHelpTooltipContent, | |||
| } from "../../constants"; | |||
|
|
|||
| const urlTooltip = | |||
There was a problem hiding this comment.
Consider extracting this tooltip text to a shared constant since it's identical to the one in NavigationNode.
- constant
urlTooltip(NavigationNode.tsx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds an editable URL input field with a tooltip to
ActionNodeinActionNode.tsx.ActionNodeinActionNode.tsx.handleChange().AutoResizingTextareafor URL input with placeholder fromcommonFieldPlaceholders.This description was created by
for 562a947. It will automatically update as commits are pushed.