-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: tooltips and placeholders #1302
Conversation
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Centralize tooltips and placeholders in `helpContent.ts` and update node components to use this centralized content. > > - **Refactor**: > - Move `commonHelpTooltipContent` and `commonFieldPlaceholders` from `constants.ts` to `helpContent.ts`. > - Create `baseHelpTooltipContent` and `basePlaceholderContent` in `helpContent.ts`. > - Define `helpTooltips` and `placeholders` in `helpContent.ts` for various node types. > - **Node Components**: > - Update `ActionNode.tsx`, `DownloadNode.tsx`, `ExtractionNode.tsx` to use `helpTooltips` and `placeholders` from `helpContent.ts`. > - Update `FileDownloadNode.tsx`, `FileParserNode.tsx`, `LoginNode.tsx` to use centralized content. > - Update `LoopNode.tsx`, `NavigationNode.tsx`, `SendEmailNode.tsx` to use centralized content. > - Update `TaskNode.tsx`, `TextPromptNode.tsx`, `UploadNode.tsx` to use centralized content. > - Update `ValidationNode.tsx`, `WaitNode.tsx` to use centralized content. > - **Types**: > - Remove `helpTooltipContent` and `fieldPlaceholders` from individual node `types.ts` files. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 06fde6a1423cc6f4342475d334f1ba929bd4914c. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Centralize tooltips and placeholders in `helpContent.ts` and update node components to use this centralized content. > > - **Refactor**: > - Move `commonHelpTooltipContent` and `commonFieldPlaceholders` from `constants.ts` to `helpContent.ts`. > - Create `baseHelpTooltipContent` and `basePlaceholderContent` in `helpContent.ts`. > - Define `helpTooltips` and `placeholders` in `helpContent.ts` for various node types. > - **Node Components**: > - Update `ActionNode.tsx`, `DownloadNode.tsx`, `ExtractionNode.tsx` to use `helpTooltips` and `placeholders` from `helpContent.ts`. > - Update `FileDownloadNode.tsx`, `FileParserNode.tsx`, `LoginNode.tsx` to use centralized content. > - Update `LoopNode.tsx`, `NavigationNode.tsx`, `SendEmailNode.tsx` to use centralized content. > - Update `TaskNode.tsx`, `TextPromptNode.tsx`, `UploadNode.tsx` to use centralized content. > - Update `ValidationNode.tsx`, `WaitNode.tsx` to use centralized content. > - **Types**: > - Remove `helpTooltipContent` and `fieldPlaceholders` from individual node `types.ts` files. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 06fde6a1423cc6f4342475d334f1ba929bd4914c. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 0e1dcf2 in 25 seconds
More details
- Looked at
1507
lines of code in26
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/FileDownloadNode/FileDownloadNode.tsx:27
- Draft comment:
Consider using the centralizedhelpTooltips
andplaceholders
for consistency.
const urlTooltip = helpTooltips["download"]["url"];
const urlPlaceholder = placeholders["download"]["url"];
- Reason this comment was not posted:
Confidence changes required:50%
The refactoring seems consistent across the files, with the centralized help content being used correctly. However, there is a minor inconsistency in theFileDownloadNode.tsx
file where theurlTooltip
andurlPlaceholder
constants are defined but not used. Instead, the centralizedhelpTooltips
andplaceholders
should be used for consistency.
Workflow ID: wflow_hf2KB1m0p2QDEJGe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 0e1dcf2 in 38 seconds
More details
- Looked at
1524
lines of code in27
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx:26
- Draft comment:
Consider usinghelpTooltips["action"]["url"]
instead of the hardcodedurlTooltip
for consistency with the centralized content. - Reason this comment was not posted:
Confidence changes required:50%
The refactoring of tooltips and placeholders is consistent across the codebase. However, there are some hardcoded tooltips and placeholders in theActionNode.tsx
file that should be replaced with the centralized content fromhelpContent.ts
.
Workflow ID: wflow_k8kAsT6TPUxnyjIh
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Centralize tooltips and placeholders in
helpContent.ts
and update node components to use this centralized content.commonHelpTooltipContent
andcommonFieldPlaceholders
fromconstants.ts
tohelpContent.ts
.baseHelpTooltipContent
andbasePlaceholderContent
inhelpContent.ts
.helpTooltips
andplaceholders
inhelpContent.ts
for various node types.ActionNode.tsx
,DownloadNode.tsx
,ExtractionNode.tsx
to usehelpTooltips
andplaceholders
fromhelpContent.ts
.FileDownloadNode.tsx
,FileParserNode.tsx
,LoginNode.tsx
to use centralized content.LoopNode.tsx
,NavigationNode.tsx
,SendEmailNode.tsx
to use centralized content.TaskNode.tsx
,TextPromptNode.tsx
,UploadNode.tsx
to use centralized content.ValidationNode.tsx
,WaitNode.tsx
to use centralized content.helpTooltipContent
andfieldPlaceholders
from individual nodetypes.ts
files.This description was created by for 9624c4c. It will automatically update as commits are pushed.