shu/removeSettingsManager.get_settings #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commit cloud/webeye/setup/action_input.py - commit - commit - commit - commit - commit - commit - commit - commit 2 more - commit more - commit more <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Replaces `SettingsManager.get_settings()` with `settings` for configuration access and adds Gemini API settings. > > - **Behavior**: > - Replaces `SettingsManager.get_settings()` with `settings` in `action_input.py`, `url.py`, and `retry_llm_request.py` for accessing configuration settings. > - Updates `run_task.py`, `run_workflow.py`, and `analytics.py` to use `settings` for configuration access. > - **Configuration**: > - Modifies `config.py` to include new settings `ENABLE_GEMINI` and `GEMINI_API_KEY`. > - **Misc**: > - Updates `__main__.py`, `api_app.py`, and `aws.py` to use `settings` for configuration. > - Changes `files.py`, `llm/api_handler_factory.py`, and `llm/config_registry.py` to use `settings`. > - Updates `local.py`, `security.py`, and `forge_log.py` to use `settings`. > - Modifies `agent_protocol.py`, `org_auth_service.py`, and `block.py` to use `settings`. > - Updates `service.py`, `handler.py`, and `models.py` to use `settings`. > - Changes `browser_factory.py`, `scraper.py`, and `dom.py` to use `settings`. > - Updates `page.py` and `temporal_activities.py` to use `settings`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for ad83813b3e5000712f5236dcb3619028d3cd2370. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5139d34 in 37 seconds
More details
- Looked at
1414lines of code in23files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:15
- Draft comment:
Ensure thatsettingsis properly initialized and imported in all contexts where it is used. This change replacesSettingsManager.get_settings()withsettings, which assumessettingsis always available and correctly configured. - Reason this comment was not posted:
Confidence changes required:50%
The PR replacesSettingsManager.get_settings()withsettingsfor configuration access. This change is consistent across the files, ensuring a uniform approach to accessing settings. However, there is a potential issue with the use ofsettingsdirectly without ensuring that it is properly initialized or imported in all contexts. This could lead to runtime errors ifsettingsis not available or correctly configured in some parts of the code.
Workflow ID: wflow_bQSulrb6rHOU8hBK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5139d34 in 1 minute and 5 seconds
More details
- Looked at
1414lines of code in23files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:374
- Draft comment:
Ensure thatsettings.BROWSER_ACTION_TIMEOUT_MSis defined and correctly configured inskyvern.config. This change replacesSettingsManager.get_settings().BROWSER_ACTION_TIMEOUT_MSwithsettings.BROWSER_ACTION_TIMEOUT_MS, which should be verified for correctness. - Reason this comment was not posted:
Confidence changes required:50%
The PR replacesSettingsManager.get_settings()withsettingsfor configuration access. This change is consistent across multiple files, includinghandler.py,models.py,browser_factory.py,scraper.py,dom.py, andpage.py. The change is straightforward and aligns with the PR description.
2. skyvern/webeye/actions/models.py:48
- Draft comment:
Ensure thatsettings.DEBUG_MODEis defined and correctly configured inskyvern.config. This change replacesSettingsManager.get_settings().DEBUG_MODEwithsettings.DEBUG_MODE, which should be verified for correctness. - Reason this comment was not posted:
Confidence changes required:50%
The PR replacesSettingsManager.get_settings()withsettingsfor configuration access. This change is consistent across multiple files, includinghandler.py,models.py,browser_factory.py,scraper.py,dom.py, andpage.py. The change is straightforward and aligns with the PR description.
3. skyvern/webeye/browser_factory.py:145
- Draft comment:
Ensure thatsettings.VIDEO_PATHis defined and correctly configured inskyvern.config. This change replacesSettingsManager.get_settings().VIDEO_PATHwithsettings.VIDEO_PATH, which should be verified for correctness. - Reason this comment was not posted:
Confidence changes required:50%
The PR replacesSettingsManager.get_settings()withsettingsfor configuration access. This change is consistent across multiple files, includinghandler.py,models.py,browser_factory.py,scraper.py,dom.py, andpage.py. The change is straightforward and aligns with the PR description.
4. skyvern/webeye/scraper/scraper.py:304
- Draft comment:
Ensure thatsettings.MAX_SCRAPING_RETRIESis defined and correctly configured inskyvern.config. This change replacesSettingsManager.get_settings().MAX_SCRAPING_RETRIESwithsettings.MAX_SCRAPING_RETRIES, which should be verified for correctness. - Reason this comment was not posted:
Confidence changes required:50%
The PR replacesSettingsManager.get_settings()withsettingsfor configuration access. This change is consistent across multiple files, includinghandler.py,models.py,browser_factory.py,scraper.py,dom.py, andpage.py. The change is straightforward and aligns with the PR description.
5. skyvern/webeye/utils/dom.py:316
- Draft comment:
Ensure thatsettings.BROWSER_ACTION_TIMEOUT_MSis defined and correctly configured inskyvern.config. This change replacesSettingsManager.get_settings().BROWSER_ACTION_TIMEOUT_MSwithsettings.BROWSER_ACTION_TIMEOUT_MS, which should be verified for correctness. - Reason this comment was not posted:
Confidence changes required:50%
The PR replacesSettingsManager.get_settings()withsettingsfor configuration access. This change is consistent across multiple files, includinghandler.py,models.py,browser_factory.py,scraper.py,dom.py, andpage.py. The change is straightforward and aligns with the PR description.
6. skyvern/webeye/utils/page.py:40
- Draft comment:
Ensure thatsettings.BROWSER_ACTION_TIMEOUT_MSis defined and correctly configured inskyvern.config. This change replacesSettingsManager.get_settings().BROWSER_ACTION_TIMEOUT_MSwithsettings.BROWSER_ACTION_TIMEOUT_MS, which should be verified for correctness. - Reason this comment was not posted:
Confidence changes required:50%
The PR replacesSettingsManager.get_settings()withsettingsfor configuration access. This change is consistent across multiple files, includinghandler.py,models.py,browser_factory.py,scraper.py,dom.py, andpage.py. The change is straightforward and aligns with the PR description.
Workflow ID: wflow_JFszqggPGVTZXMLH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Replaces
SettingsManager.get_settings()withsettingsacross multiple files for configuration access and adds Gemini API settings.SettingsManager.get_settings()withsettingsinaction_input.py,url.py, andretry_llm_request.pyfor accessing configuration settings.run_task.py,run_workflow.py, andanalytics.pyto usesettingsfor configuration access.config.pyto include new settingsENABLE_GEMINIandGEMINI_API_KEY.__main__.py,api_app.py, andaws.pyto usesettingsfor configuration.files.py,llm/api_handler_factory.py, andllm/config_registry.pyto usesettings.local.py,security.py, andforge_log.pyto usesettings.agent_protocol.py,org_auth_service.py, andblock.pyto usesettings.service.py,handler.py, andmodels.pyto usesettings.browser_factory.py,scraper.py, anddom.pyto usesettings.page.pyandtemporal_activities.pyto usesettings.This description was created by
for 5139d34. It will automatically update as commits are pushed.