use common logic when building task response

[LawyZheng]

Important

Refactor task response construction by centralizing logic in build_task_response in agent.py, ensuring consistent handling of browser logs and failure reasons.

• Refactoring:
  • Introduced build_task_response in agent.py to centralize task response construction.
  • Replaced direct task response construction with build_task_response in execute_task_webhook, get_task, and retry_webhook.
• Behavior:
  • Task responses now consistently include browser logs and failure reasons when applicable.
  • Improved error logging for missing action screenshots in agent.py.
• Imports:
  • Added TaskResponse import in agent.py.
  • Removed unused ArtifactType import in agent_protocol.py.

^{This description was created by for 7f1155b. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7f1155b in 1 minute and 25 seconds

More details

• Looked at 289 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern/forge/agent.py:1572

• Draft comment:
  Consider instantiating httpx.AsyncClient() outside the try block and using it within a context manager to ensure proper resource management.

async with httpx.AsyncClient() as client:
    resp = await client.post(

• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a new method build_task_response to centralize the logic for building task responses. This method is now used in multiple places, replacing the previous inline logic. However, there is a potential issue with the httpx.AsyncClient() usage. The client should be instantiated outside the try block to ensure proper resource management and should be closed after use.

2. skyvern/forge/agent.py:1591

• Draft comment:
  Consider closing the httpx.AsyncClient() after use to ensure proper resource management. This can be done by using a context manager as suggested in the previous comment.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a new method build_task_response to centralize the logic for building task responses. This method is now used in multiple places, replacing the previous inline logic. However, there is a potential issue with the httpx.AsyncClient() usage. The client should be instantiated outside the try block to ensure proper resource management and should be closed after use.

Workflow ID: wflow_Yuoy04Cm1Rgw4a0Y

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.