loop task #1317
loop task #1317
Conversation
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Adds support for 'loop' task type with no-op handling, new models, and prompt templates in `run_observer.py` and `block.py`. > > - **Behavior**: > - Adds no-op handling for `loop` task type in `run_observer()` in `run_observer.py`. > - Logs unsupported task types and marks workflow as failed if encountered. > - **Prompts**: > - Adds `generate_loop_task.j2` and `loop_task_extraction_goal.j2` for loop task handling. > - Updates `observer.j2` to include `loop` task type. > - **Models**: > - Adds `ForLoopBlock` and `LoopExtractionOutput` classes in `block.py`. > - Updates `Block` class to handle loop-specific context and execution. > - **Functions**: > - Implements `_generate_loop_task()` in `run_observer.py` to create loop tasks. > - Modifies `execute()` in `ForLoopBlock` to handle loop execution logic. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for a645a32d99681bab465b2f98c75dab4f4754cba2. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
wintonzheng
force-pushed
the
shu/loop_task
branch
from
1ad2184 to
d1858f5
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d1858f5 in 36 seconds
More details
- Looked at
39lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_a5FGPTDDMNhttUYC
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -598,9 +598,6 @@ def get_all_parameters( | |||
| return list(parameters) | |||
|
|
|||
| def get_loop_block_context_parameters(self, workflow_run_id: str, loop_data: Any) -> list[ContextParameter]: | |||
There was a problem hiding this comment.
Consider re-adding the type check for loop_data to ensure it is either a dict or a list. This prevents potential runtime errors if loop_data is of an unexpected type.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on d1858f5 in 46 seconds
More details
- Looked at
39lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_JTfyiLUwqJUHCRmX
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -598,9 +598,6 @@ def get_all_parameters( | |||
| return list(parameters) | |||
|
|
|||
| def get_loop_block_context_parameters(self, workflow_run_id: str, loop_data: Any) -> list[ContextParameter]: | |||
There was a problem hiding this comment.
Consider re-adding the validation for loop_data to ensure it is either a dict or a list. This prevents unexpected errors if the input data type is incorrect.
No description provided.