Add parameter examples to login and navigation #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/'
<!-- ELLIPSIS_HIDDEN -->
> [!IMPORTANT]
> Add parameter examples to `navigationGoal` in `helpContent.ts` for navigation and login placeholders.
>
> - **Help Content Updates**:
> - Updated `navigationGoal` in `baseHelpTooltipContent` to include parameter reference example `{{ parameter_name }}`.
> - Updated `navigationGoal` in `placeholders` for `navigation` to "Navigate to the product page for product with id {{ product_id }}".
> - Updated `navigationGoal` in `placeholders` for `login` to "Login to the website using the {{ credentials }}".
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 593be5a2d088766d4b72ff89984be84d4df369fb. It will automatically update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 363be39 in 15 seconds
More details
- Looked at
34lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/helpContent.ts:118
- Draft comment:
TheloginhelpTooltip still usesbaseHelpTooltipContentwithout the updatednavigationGoal. Consider updating it to match the placeholder changes. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_UbsBAom6udwRraqH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 363be39 in 26 seconds
More details
- Looked at
34lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/helpContent.ts:100
- Draft comment:
Consider updating thenavigationGoalto include parameter examples for consistency with other placeholders. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_jwMXHUQKLolqMBu3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add parameter examples to
navigationGoalinhelpContent.tsfor navigation and login placeholders.navigationGoalinbaseHelpTooltipContentto include parameter reference example{{ parameter_name }}.navigationGoalinplaceholdersfornavigationto "Navigate to the product page for product with id {{ product_id }}".navigationGoalinplaceholdersforloginto "Login to the website using the {{ credentials }}".This description was created by
for 363be39. It will automatically update as commits are pushed.