Show downloaded files in workflow run #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add display of downloaded files in workflow run UI by updating API response and rendering in `WorkflowRun.tsx`. > > - **API Changes**: > - Add `downloaded_file_urls` to `WorkflowRunStatusApiResponse` in `types.ts`. > - **UI Changes**: > - In `WorkflowRun.tsx`, display downloaded files section if `workflowRunIsFinalized`. > - Render list of file URLs with `FileIcon` and link in `WorkflowRun.tsx`. > - Show message "No files downloaded" if `fileUrls` is empty in `WorkflowRun.tsx`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 80212eb7df6a1de9b7a7043e4e92dff1840b1e2b. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9416c59 in 9 seconds
More details
- Looked at
64lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:640
- Draft comment:
Using the URL as a key in the map function can lead to potential issues if URLs are not unique. Consider using a more descriptive and unique key if possible. - Reason this comment was not posted:
Confidence changes required:50%
The code correctly checks if the workflow run is finalized before displaying the downloaded files. However, the use ofkeyin the map function should be more descriptive to avoid potential issues with React's reconciliation process.
Workflow ID: wflow_ZD1ZsEF4GAUoaHbJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9416c59 in 31 seconds
More details
- Looked at
64lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:641
- Draft comment:
Useh-6 w-6instead ofsize-6for theFileIconcomponent to correctly apply Tailwind CSS classes for size. - Reason this comment was not posted:
Marked as duplicate.
2. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:52
- Draft comment:
Useh-6 w-6instead ofsize-6for theFileIconcomponent to correctly apply Tailwind CSS classes for size. This issue is also present on line 641. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_ObIqGWgbyUi35nLn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add display of downloaded files in workflow run UI by updating API response and rendering in
WorkflowRun.tsx.downloaded_file_urlstoWorkflowRunStatusApiResponseintypes.ts.WorkflowRun.tsx, display downloaded files section ifworkflowRunIsFinalized.FileIconand link inWorkflowRun.tsx.fileUrlsis empty inWorkflowRun.tsx.This description was created by
for 9416c59. It will automatically update as commits are pushed.