urlencode download suffix

[LawyZheng]

Important

Encode download_suffix in BaseTaskBlock to prevent invalid path styles.

• Behavior:
  • Encode download_suffix using urllib.parse.quote in format_potential_template_parameters() in BaseTaskBlock to prevent invalid path styles.

^{This description was created by for 06ab839. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 06ab839 in 12 seconds

More details

• Looked at 21 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/workflow/models/block.py:250

• Draft comment:
  Consider using quote_plus instead of quote if spaces in the download_suffix should be encoded as + instead of %20.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of quote with safe="" is correct for encoding the download suffix, but it might be more appropriate to use quote_plus if spaces need to be encoded as + instead of %20. This depends on the intended use of the encoded string.

Workflow ID: wflow_dQXJJs6pVl4fZAsj

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.