Fix a navigation bug with saved tasks #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/'
<!-- ELLIPSIS_HIDDEN -->
> [!IMPORTANT]
> Fixes navigation bug in `SavedTaskCard` by updating `navigate` call to use correct path format.
>
> - **Bug Fix**:
> - Fixes navigation bug in `SavedTaskCard` component by updating `navigate` call to use `/tasks/create/${workflowId}` instead of just `workflowId`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 56717c8c6f69ccee3fecf2af9c73828749c957be. It will automatically update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to cc77011 in 8 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/SavedTaskCard.tsx:159
- Draft comment:
Ensure the navigate path is consistent with the updated path format used in the Button onClick. - Reason this comment was not posted:
Confidence changes required:50%
The navigate function is used twice, once in the CardContent onClick and once in the Button onClick. Both should use the same path format for consistency.
Workflow ID: wflow_P14387q0i9TJCvqS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cc77011 in 11 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/SavedTaskCard.tsx:159
- Draft comment:
The navigation path update is correct and aligns with the intended fix. - Reason this comment was not posted:
Confidence changes required:0%
The change correctly updates the navigation path to include/tasks/create/before theworkflowId, which aligns with the intended fix described in the PR.
Workflow ID: wflow_3svayFd5lFcqD0iX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes navigation bug in
SavedTaskCardby updatingnavigatecall to use correct path format.SavedTaskCardby updatingnavigatecall to use/tasks/create/${workflowId}instead of justworkflowId.This description was created by
for cc77011. It will automatically update as commits are pushed.