fix streaming bug

[LawyZheng]

Important

Replaced file path management in run_streaming.py and added a FIXME for correct S3 upload organization ID.

• File Path Management:
  • Replaced SettingsManager.get_settings().STREAMING_FILE_BASE_PATH with get_skyvern_temp_dir() in run_streaming.py to determine the directory for saving screenshots.
• TODOs:
  • Added FIXME comment to address the need for using the correct organization ID when uploading screenshots to S3 in run_streaming.py.

^{This description was created by for 7e3a4a2. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7e3a4a2 in 1 minute and 41 seconds

More details

• Looked at 31 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. run_streaming.py:21

• Draft comment:
  Using shell=True in subprocess.run can be a security risk. Consider using a list of arguments instead of a single string to avoid shell injection vulnerabilities.
• Reason this comment was not posted:
  Comment was on unchanged code.

2. run_streaming.py:27

• Draft comment:
  Catching a broad Exception is not recommended. Consider catching more specific exceptions to avoid masking other issues.
• Reason this comment was not posted:
  Comment was on unchanged code.

3. run_streaming.py:24

• Draft comment:
  The FIXME comment indicates that the organization ID is a placeholder. Ensure this is updated with the correct ID before deployment.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The FIXME comment indicates that the organization ID is a placeholder and needs to be replaced with the correct one. This is a known issue that needs to be addressed.

Workflow ID: wflow_OLbYGyiYOFpfj7iC

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.