Add tooltips to action and navigation blocks #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add tooltips to `ActionNode.tsx` and `NavigationNode.tsx` to provide execution guidance. > > - **UI Enhancements**: > - Added tooltips to `ActionNode.tsx` and `NavigationNode.tsx`. > - `ActionNode.tsx`: Tooltip explains that only one action is taken during execution. > - `NavigationNode.tsx`: Tooltip explains that multiple actions are taken to achieve a single goal. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for bb541e45e4b46a103484dc6f8ebd2cac1a256599. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7bf5793 in 8 seconds
More details
- Looked at
44lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx:148
- Draft comment:
Consider extracting the tooltip text into a constants or localization file for easier maintenance and potential localization. This applies to the tooltip in NavigationNode as well. - Reason this comment was not posted:
Confidence changes required:50%
The tooltip text is hardcoded in both ActionNode and NavigationNode components. It would be better to extract these strings into a constants file or a localization file for easier maintenance and potential localization.
Workflow ID: wflow_QcIOKxK0yoFsDM6g
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7bf5793 in 12 seconds
More details
- Looked at
44lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/ActionNode/ActionNode.tsx:148
- Draft comment:
Consider rephrasing the tooltip for clarity and conciseness.
Tip: Skyvern executes one action in this block.
- Reason this comment was not posted:
Confidence changes required:50%
The tooltip addition is consistent with the PR description and enhances the UI by providing execution guidance. However, the tooltip text could be more concise and clear.
2. skyvern-frontend/src/routes/workflows/editor/nodes/NavigationNode/NavigationNode.tsx:134
- Draft comment:
Consider rephrasing the tooltip for clarity and conciseness.
Tip: Skyvern executes multiple actions to achieve a goal in this block.
- Reason this comment was not posted:
Confidence changes required:50%
The tooltip addition is consistent with the PR description and enhances the UI by providing execution guidance. However, the tooltip text could be more concise and clear.
Workflow ID: wflow_B7UcEHNI86eVsF1Q
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add tooltips to
ActionNode.tsxandNavigationNode.tsxfor execution guidance.ActionNode.tsxandNavigationNode.tsx.ActionNode.tsx: Tooltip explains that only one action is taken during execution.NavigationNode.tsx: Tooltip explains that multiple actions are taken to achieve a single goal.This description was created by
for 7bf5793. It will automatically update as commits are pushed.