Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hack input trigger #1392

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix hack input trigger #1392

merged 1 commit into from
Dec 16, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Dec 16, 2024

Important

Add condition in handle_input_text_action to check for raw input before triggering auto-completion hack.

  • Behavior:
    • In handle_input_text_action in handler.py, add a condition to check not await skyvern_element.is_raw_input() before triggering the auto-completion hack.
  • Logging:
    • Add debug log in handle_input_text_action to indicate when the input-selection hack is triggered.

This description was created by Ellipsis for 22af91c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 22af91c in 14 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:663
  • Draft comment:
    The added condition not await skyvern_element.is_raw_input() is a logical improvement to prevent unnecessary actions on raw input elements. This ensures that the hack is only triggered when needed.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR adds a condition to check if the element is a raw input before triggering the input-selection hack. This seems to be a logical improvement to avoid unnecessary actions on raw input elements.

Workflow ID: wflow_qZHyxChiiepYFmtH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 245cd1c into main Dec 16, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-hack-input-trigger branch December 16, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant