Add ability to use observer in the prompt section #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add observer functionality in `PromptBox` with version selection and mutation handling, controlled by `VITE_OBSERVER_ENABLED`. > > - **Behavior**: > - Add observer functionality in `PromptBox.tsx` with version selection (`v1`, `v2`). > - `v2` triggers `startObserverCruiseMutation` for observer cruise. > - Success and error toasts for observer cruise. > - **Types**: > - Add `ObserverCruise` type in `types.ts`. > - **UI Components**: > - Add `CustomSelectItem` and `SelectItemText` in `select.tsx` for custom select UI. > - **Environment**: > - Add `observerFeatureEnabled` in `env.ts` to control observer feature based on `VITE_OBSERVER_ENABLED`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 393a2763ea5281d209b15dceeb2aca9bd14debff. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1543e72 in 40 seconds
More details
- Looked at
233lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. skyvern-frontend/src/util/env.ts:22
- Draft comment:
Consider using a boolean environment variable forVITE_OBSERVER_ENABLEDinstead of casting it to a string and comparing it to "true". - Reason this comment was not posted:
Confidence changes required:50%
TheobserverEnabledvariable is cast to a string, but it should be a boolean since it's being compared to the string "true". This can be simplified by directly using a boolean environment variable.
2. skyvern-frontend/src/components/ui/select.tsx:117
- Draft comment:
CustomSelectItemandSelectItemhave similar implementations. Consider refactoring to avoid code duplication. - Reason this comment was not posted:
Confidence changes required:50%
TheCustomSelectItemandSelectItemcomponents have similar implementations. Consider refactoring to avoid code duplication.
3. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:164
- Draft comment:
Ensure error messages are user-friendly and provide actionable feedback. - Reason this comment was not posted:
Confidence changes required:33%
ThestartObserverCruiseMutationandgetTaskFromPromptMutationboth handle errors by displaying a toast with the error message. This is a good practice for user feedback.
Workflow ID: wflow_OJQ0jIPcV2c0vyR0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 1543e72 in 1 minute and 33 seconds
More details
- Looked at
233lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/components/ui/select.tsx:117
- Draft comment:
CustomSelectItemandSelectItemhave similar implementations. Consider reusing one component or extracting common logic to avoid redundancy. - Reason this comment was not posted:
Confidence changes required:50%
TheCustomSelectItemandSelectItemcomponents have almost identical implementations. This redundancy can be reduced by reusing one component or extracting common logic.
2. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:132
- Draft comment:
getClient(credentialGetter)is used in multiple mutation functions. Consider extracting this to a common function to avoid redundancy. - Reason this comment was not posted:
Confidence changes required:50%
ThestartObserverCruiseMutationandgetTaskFromPromptMutationfunctions both usegetClient(credentialGetter)to get a client. This can be extracted to a common function to avoid redundancy.
Workflow ID: wflow_P44Z0BR1a02YVqxX
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -19,4 +19,13 @@ if (!artifactApiBaseUrl) { | |||
| console.warn("artifactApiBaseUrl environment variable was not set"); | |||
| } | |||
|
|
|||
| export { apiBaseUrl, environment, envCredential, artifactApiBaseUrl }; | |||
| const observerEnabled = import.meta.env.VITE_OBSERVER_ENABLED as string; | |||
There was a problem hiding this comment.
Consider casting observerEnabled to a boolean directly when importing it, instead of comparing it to the string "true". This will ensure that observerFeatureEnabled is a boolean value.
Suggested change
| const observerEnabled = import.meta.env.VITE_OBSERVER_ENABLED as string; | |
| const observerFeatureEnabled = import.meta.env.VITE_OBSERVER_ENABLED === "true"; |
| @@ -114,6 +114,30 @@ const SelectLabel = React.forwardRef< | |||
| )); | |||
| SelectLabel.displayName = SelectPrimitive.Label.displayName; | |||
|
|
|||
| const CustomSelectItem = React.forwardRef< | |||
There was a problem hiding this comment.
This appears to be a duplicate of SelectItem. Consider using the existing component instead.
- component
SelectItem(select.tsx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add observer functionality in
PromptBoxwith version selection and mutation handling, controlled byVITE_OBSERVER_ENABLED.PromptBox.tsxwith version selection (v1,v2).v2triggersstartObserverCruiseMutationfor observer cruise.ObserverCruisetype intypes.ts.CustomSelectItemandSelectItemTextinselect.tsxfor custom select UI.observerFeatureEnabledinenv.tsto control observer feature based onVITE_OBSERVER_ENABLED.This description was created by
for 1543e72. It will automatically update as commits are pushed.