Explicitly state url is optional in workflow blocks #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Update `url` placeholder in `basePlaceholderContent` in `helpContent.ts` to indicate it is optional. > > - **Documentation**: > - Update `url` placeholder in `basePlaceholderContent` in `helpContent.ts` to indicate it is optional by changing the text to "(optional) Navigate to this URL: https://...". > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for abfc5d15fdf8956214b68779fde77a56425045a7. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a806216 in 10 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/helpContent.ts:30
- Draft comment:
The change correctly updates the placeholder to indicate the URL is optional, as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The change in the PR is consistent with the description and correctly updates the placeholder to indicate the URL is optional.
Workflow ID: wflow_PUF3arR1YZ9RCZgh
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a806216 in 12 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/helpContent.ts:30
- Draft comment:
The change correctly updates the placeholder text to indicate that the URL is optional, as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The change in the PR is consistent with the description and correctly updates the placeholder text to indicate that the URL is optional.
Workflow ID: wflow_EgCzg0hXwKxKwn7Z
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
urlplaceholder inhelpContent.tsto indicate it is optional.urlplaceholder inbasePlaceholderContentinhelpContent.tsto indicate it is optional by changing the text to "(optional) Navigate to this URL: https://...".This description was created by
for a806216. It will automatically update as commits are pushed.