make observer thought artifacts work #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 29268b6 in 25 seconds
More details
- Looked at
112lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern/forge/sdk/db/client.py:2007
- Draft comment:
Consider includingorganization_idin theNotFoundErrormessage for better debugging context. - Reason this comment was not posted:
Confidence changes required:50%
Theupdate_observer_thoughtmethod inclient.pyraises aNotFoundErrorwith a message that doesn't include theorganization_id. This could make debugging difficult if the error is raised because theorganization_iddoesn't match. Including theorganization_idin the error message would provide more context.
2. skyvern/forge/sdk/services/observer_service.py:231
- Draft comment:
Consider defaultingint_max_iterations_overridetoDEFAULT_MAX_ITERATIONSifmax_iterations_overrideis not set or is invalid. - Reason this comment was not posted:
Confidence changes required:50%
Therun_observer_cruisefunction inobserver_service.pyhas a potential issue with theint_max_iterations_overridevariable. Ifmax_iterations_overrideis not provided or is not an integer,int_max_iterations_overrideremainsNone, which could lead to unexpected behavior in the loop. It would be safer to defaultint_max_iterations_overridetoDEFAULT_MAX_ITERATIONSif it's not set.
Workflow ID: wflow_y3RMqz5yPAAWt2nk
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 29268b6 in 1 minute and 21 seconds
More details
- Looked at
112lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/db/client.py:2007
- Draft comment:
Ensureorganization_idis checked before raisingNotFoundErrorto prevent unauthorized access to observer thoughts from different organizations. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_DAITk1myuvsHmqaE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Enhance observer thought handling by adding `OBSERVER_THOUGHT` log entity type and updating observer thought processes in `client.py` and `observer_service.py`. > > - **Behavior**: > - Add `OBSERVER_THOUGHT` to `LogEntityType` in `models.py`. > - Implement `update_observer_thought()` in `client.py` to update observer thoughts with fields like `workflow_run_block_id`, `observation`, `thought`, and `answer`. > - Modify `run_observer_cruise()` in `observer_service.py` to create and update observer thoughts during the observer cruise process. > - **Database**: > - Add `update_observer_thought()` method in `client.py` to handle updates to `ObserverThoughtModel`. > - **Service**: > - Update `run_observer_cruise()` in `observer_service.py` to use `create_observer_thought()` and `update_observer_thought()` for handling observer thoughts. > - **Misc**: > - Add `OBSERVER_THOUGHT` to `EntityType` in `agent_protocol.py`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for fd92b851c149a2d27cec0fc4121e6e020c950c99. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
wintonzheng
force-pushed
the
shu/artifacts_for_observer_thought
branch
from
29268b6 to
44f93d1
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 44f93d1 in 23 seconds
More details
- Looked at
112lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/artifact/models.py:87
- Draft comment:
AddOBSERVER_THOUGHTtoLogEntityTypeto match the PR description and ensure consistency.
OBSERVER_THOUGHT = "observer_thought"
- Reason this comment was not posted:
Comment position is out of bounds for file skyvern/forge/sdk/artifact/models.py; line 88 but file only has 87 lines
Workflow ID: wflow_SpyWcc03TqrTc0r1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance observer thought handling by adding
OBSERVER_THOUGHTlog entity type and updating observer thought processes inclient.pyandobserver_service.py.OBSERVER_THOUGHTtoLogEntityTypeinmodels.py.update_observer_thought()inclient.pyto update observer thoughts with fields likeworkflow_run_block_id,observation,thought, andanswer.run_observer_cruise()inobserver_service.pyto create and update observer thoughts during the observer cruise process.update_observer_thought()method inclient.pyto handle updates toObserverThoughtModel.run_observer_cruise()inobserver_service.pyto usecreate_observer_thought()andupdate_observer_thought()for handling observer thoughts.OBSERVER_THOUGHTtoEntityTypeinagent_protocol.py.This description was created by
for 44f93d1. It will automatically update as commits are pushed.