Use free input for loop value parameter #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Replaces dropdown with free input for loop value in `LoopNode.tsx` and updates error handling in `workflowEditorUtils.ts`. > > - **Behavior**: > - Replaces dropdown with `WorkflowBlockInput` for `loopValue` in `LoopNode.tsx`. > - Updates error message in `getWorkflowErrors()` to "Loop value parameter is required." > - **UI Components**: > - Removes `Select`, `SelectContent`, `SelectItem`, `SelectTrigger`, `SelectValue` imports from `LoopNode.tsx`. > - **Error Handling**: > - Updates error message for empty loop nodes in `getWorkflowErrors()` in `workflowEditorUtils.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b6ec8becfa53265a648b4cc02d0f29c3ffed5fcb. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3b6c730 in 10 seconds
More details
- Looked at
104lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:1691
- Draft comment:
The error message for empty loop nodes has been updated to 'Loop value parameter is required.' This aligns with the PR description and is a valid change. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions updating the error message for empty loop nodes. The change in the code reflects this update, changing the message from 'Loop value parameter must be selected.' to 'Loop value parameter is required.' This aligns with the PR description and is a valid change.
Workflow ID: wflow_QwnjrA5NszbCmq65
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3b6c730 in 21 seconds
More details
- Looked at
104lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/LoopNode/LoopNode.tsx:12
- Draft comment:
Remove unused importuseEdges. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_EXr1Ch9xJh0YfWnN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Replaces dropdown with free input for loop value in
LoopNode.tsxand updates error handling inworkflowEditorUtils.ts.WorkflowBlockInputforloopValueinLoopNode.tsx.getWorkflowErrors()to "Loop value parameter is required."Select,SelectContent,SelectItem,SelectTrigger,SelectValueimports fromLoopNode.tsx.getWorkflowErrors()inworkflowEditorUtils.ts.This description was created by
for 3b6c730. It will automatically update as commits are pushed.