Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow timeline in reversed order #1501

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 6, 2025

Important

Reverse order of workflow timeline events in get_workflow_run_timeline() by sorting in descending order of created_at.

  • Behavior:
    • Reverse order of workflow timeline events in get_workflow_run_timeline() in agent_protocol.py by sorting workflow_run_block_timeline in descending order of created_at.

This description was created by Ellipsis for 1b0c199. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 617dc54 in 14 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/routes/agent_protocol.py:766
  • Draft comment:
    Removing the sort operation on workflow_run_block_timeline may lead to unexpected behavior if other parts of the application expect this list to be sorted by created_at. Ensure that the timeline is correctly ordered as intended by the application logic.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_PpwyoAmr7MvhXF8s


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng force-pushed the shu/fix_workflow_timeline_attempt2 branch from 617dc54 to 1b0c199 Compare January 6, 2025 15:27
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 1b0c199 in 14 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/routes/agent_protocol.py:766
  • Draft comment:
    Ensure that reversing the sort order does not affect other parts of the codebase that rely on the original order. Consider adding a comment to clarify the reason for the reverse sort for future reference.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR is straightforward, reversing the sort order of the workflow timeline events. This aligns with the PR description and intent. No issues with the change itself, but it's important to ensure that the rest of the codebase that depends on this order is aware of the change.

Workflow ID: wflow_FmheFJOmYJ4b4dpn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit c0bf638 into main Jan 6, 2025
2 checks passed
@wintonzheng wintonzheng deleted the shu/fix_workflow_timeline_attempt2 branch January 6, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant