Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make observer prompt resize #1506

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 6, 2025

Important

Replace Input with AutoResizingTextarea in WorkflowPostRunParameters.tsx for multi-line observer prompt display.

  • UI Update:
    • Replace Input with AutoResizingTextarea for workflowRun.observer_cruise.prompt in WorkflowPostRunParameters.tsx to support multi-line text display.

This description was created by Ellipsis for 0e7f8e8. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Replace `Input` with `AutoResizingTextarea` for observer prompt in `WorkflowPostRunParameters.tsx`.
>
>   - **UI Update**:
>     - Replace `Input` with `AutoResizingTextarea` for `workflowRun.observer_cruise.prompt` in `WorkflowPostRunParameters.tsx` to support multi-line text display.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for eef107b462d2beee8a3208b2eec4ac70dcc12c8d. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0e7f8e8 in 7 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_o7M9hWDthNzsTPxA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 0e7f8e8 in 13 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:154
  • Draft comment:
    The replacement of Input with AutoResizingTextarea is correct and supports multi-line text display as intended.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly replaces Input with AutoResizingTextarea for the observer prompt, which aligns with the intent to support multi-line text display. No issues found with this change.

Workflow ID: wflow_uasFUhZvtrWUl0qC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 345309f into main Jan 6, 2025
2 checks passed
@msalihaltun msalihaltun deleted the make-observer-prompt-text-area branch January 6, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants