Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix date picker issue #1523

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix date picker issue #1523

merged 1 commit into from
Jan 9, 2025

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Jan 9, 2025

Important

Enhance date picker handling by skipping remaining actions when necessary and updating templates and DOM utilities for better support.

  • Behavior:
    • In agent.py, added logic to skip remaining actions if results[-1].skip_remaining_actions is True.
    • In handler.py, added logic to skip remaining actions for date pickers after two mini actions in sequentially_select_from_dropdown().
  • Templates:
    • Updated custom-select.j2 to include date picker handling instructions.
    • Updated opened-dropdown-confirm.j2 to consider multiple input fields as dropdowns.
    • Updated parse-input-or-select-context.j2 to include is_date_related field.
  • DOM and Actions:
    • Added is_date_related to InputOrSelectContext in actions.py.
    • Added isDatePickerSelector() function in domUtils.js to identify date picker elements.
    • Modified buildElementObject() in domUtils.js to recognize date picker selectors.

This description was created by Ellipsis for 2a55fe9. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2a55fe9 in 1 minute and 56 seconds

More details
  • Looked at 446 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:187
  • Draft comment:
    The function check_id_in_dom is now asynchronous and should be awaited to ensure it completes before proceeding.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. skyvern/webeye/actions/handler.py:575
  • Draft comment:
    The function check_id_in_dom is now asynchronous and should be awaited to ensure it completes before proceeding.
  • Reason this comment was not posted:
    Marked as duplicate.
3. skyvern/webeye/actions/handler.py:622
  • Draft comment:
    The function check_id_in_dom is now asynchronous and should be awaited to ensure it completes before proceeding.
  • Reason this comment was not posted:
    Marked as duplicate.
4. skyvern/webeye/actions/handler.py:1085
  • Draft comment:
    The function check_id_in_dom is now asynchronous and should be awaited to ensure it completes before proceeding.
  • Reason this comment was not posted:
    Marked as duplicate.
5. skyvern/webeye/actions/handler.py:1557
  • Draft comment:
    The function check_id_in_dom is now asynchronous and should be awaited to ensure it completes before proceeding.
  • Reason this comment was not posted:
    Marked as duplicate.
6. skyvern/webeye/actions/handler.py:1928
  • Draft comment:
    The function check_id_in_dom is now asynchronous and should be awaited to ensure it completes before proceeding.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_Zf7yL9AqAob24XaY


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit dc53a49 into main Jan 9, 2025
6 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-date-picker branch January 9, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant