Bitwarden updates #1547
Merged
Bitwarden updates #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Adds `bitwarden_helper.py` for Bitwarden session management, updates error handling in `bitwarden.py`, and modifies command examples in `restart_task.py` and `restart_workflow.py`. > > - **New Script**: > - Adds `bitwarden_helper.py` to `dev_scripts` for generating Bitwarden session keys and running custom commands. > - **Error Handling**: > - In `bitwarden.py`, adds error handling for missing organization or collection IDs in `_get_sensitive_information_from_identity()` and `_get_credit_card_data()`. > - **Scripts Update**: > - Removes hardcoded '7' from command examples in `restart_task.py` and `restart_workflow.py`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 1dd86e3142b63ae73e56869b7cb377f4f08f4c90. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b3f815a in 23 seconds
More details
- Looked at
51lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/bitwarden.py:580
- Draft comment:
Consider re-adding the check forbw_organization_idandbw_collection_idshere to maintain consistency with other functions like_get_credit_card_dataand_get_sensitive_information_from_identity. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_186RuMxxRj9YMcEF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b3f815a in 33 seconds
More details
- Looked at
51lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/bitwarden.py:580
- Draft comment:
The check forbw_organization_idandbw_collection_idswas removed here, but similar checks were added in other functions. Consider adding a similar check here for consistency and to prevent potential access issues. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_oEuRKSVCU17up12X
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
LawyZheng
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improved error handling in Bitwarden operations by ensuring organization and collection IDs are required, with appropriate error logging and redundant checks removed.
bitwarden.py, added checks in_get_sensitive_information_from_identity()and_get_credit_card_data()to raiseBitwardenAccessDeniedErrorif bothbw_organization_idandcollection_idare not provided.bw_organization_idandbw_collection_idsinget_credit_card_data()._get_credit_card_data()inbitwarden.pywhen nocollection_idororganization_idis provided.create_workflow_from_request()inservice.pyfor missingbw_organization_idandbw_collection_ids.This description was created by
for b3f815a. It will automatically update as commits are pushed.