generate warning if there's no plan in observer response #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add warning log in `run_observer_cruise_helper()` when no plan is found in observer response. > > - **Logging**: > - Add warning log in `run_observer_cruise_helper()` in `observer_service.py` when no plan is found in observer response. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for cd6df3c7bffa46988efa2e613ed188ceaaf32d03. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f9e520b in 10 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/observer_service.py:395
- Draft comment:
Consider including more context in the warning log, such as the iteration number or workflow_run_id, to aid in debugging. - Reason this comment was not posted:
Confidence changes required:50%
The warning log should include more context for better debugging.
Workflow ID: wflow_WfO9Ny8gShrcYG2s
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f9e520b in 8 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/observer_service.py:395
- Draft comment:
Consider including more context in the warning log, such as the iteration number or workflow_run_id, to aid in debugging. - Reason this comment was not posted:
Confidence changes required:50%
The warning log should include more context for better debugging.
Workflow ID: wflow_a4LW1L88hhbrvVNE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add warning log in
run_observer_cruise_helper()when no plan is found in observer response.run_observer_cruise_helper()inobserver_service.pywhen no plan is found in observer response.This description was created by
for f9e520b. It will automatically update as commits are pushed.