Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow run / observer schema #1571

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 16, 2025

Important

Rename observer_cruise to observer_task in WorkflowRunStatusResponse and exclude a route from schema in agent_protocol.py.

  • Models:
    • Rename observer_cruise to observer_task in WorkflowRunStatusResponse class in workflow.py.
  • Routes:
    • Mark /workflows/{workflow_id}/runs/{workflow_run_id}/timeline/ route in agent_protocol.py to be excluded from the schema.

This description was created by Ellipsis for 7d47e89. It will automatically update as commits are pushed.

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Rename `observer_cruise` to `observer_task` in `WorkflowRunStatusResponse` and exclude a route from schema in `agent_protocol.py`.
>
>   - **Models**:
>     - Rename `observer_cruise` to `observer_task` in `WorkflowRunStatusResponse` in `workflow.py`.
>   - **Routes**:
>     - Mark `/workflows/{workflow_id}/runs/{workflow_run_id}/timeline/` route in `agent_protocol.py` to be excluded from the schema.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for a72ddec0990059efc9edb1a8fdab4c385bc4c23c. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 7d47e89 in 12 seconds

More details
  • Looked at 22 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/workflow.py:141
  • Draft comment:
    Renamed observer_cruise to observer_task for consistency. Ensure all references are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from observer_cruise to observer_task in the WorkflowRunStatusResponse class aligns with the change in the code where observer_cruise is replaced with observer_task. This change seems to be a renaming for consistency or clarity.

Workflow ID: wflow_2saUCt7EWAn9Dtkd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7d47e89 in 13 seconds

More details
  • Looked at 22 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/workflow.py:141
  • Draft comment:
    Renamed observer_cruise to observer_task to match the updated schema in get_workflow_run.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_KooTy5yoXx7wXSIy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 1d5dc90 into main Jan 16, 2025
6 checks passed
@wintonzheng wintonzheng deleted the shu/fix_workflow_timeline_schema branch January 16, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant