Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max iteration errors #1589

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 17, 2025

Important

Update failure message in run_observer_cruise_helper function to "Max iterations reached".

  • Behavior:
    • Update failure message in run_observer_cruise_helper function from "Observer max iterations reached" to "Max iterations reached".

This description was created by Ellipsis for 8a103e5. It will automatically update as commits are pushed.

@wintonzheng wintonzheng merged commit bb834fa into main Jan 17, 2025
6 checks passed
@wintonzheng wintonzheng deleted the shu/update_max_iteration_error branch January 17, 2025 17:04
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8a103e5 in 56 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/services/observer_service.py:606
  • Draft comment:
    The change in the failure reason message is appropriate and makes it more concise. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the failure reason message is minor but aligns with the intent to make it more concise. There are no issues with this change.

Workflow ID: wflow_gVjPpP7B8e0CUpJi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant