migrate aiohttp helper from cloud to open source #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 3323cc377c127ab276c06f2372d0809de38d1c93 | |--------|--------| ### Summary: Migrated `aiohttp_helper` module and `HttpException` class from `cloud` to `skyvern` package, updating import paths accordingly. **Key points**: - Migrated `aiohttp_helper` from `cloud` to `skyvern` package. - Updated import paths for `aiohttp_get_json` in `cloud/core/authentication.py`, `cloud/core/mihomo/mihomo.py`, `cloud/webeye/proxy.py`, and `scripts/luca/walmart_client.py`. - Moved `aiohttp_helper.py` from `cloud/core/aiohttp_helper.py` to `skyvern/forge/sdk/core/aiohttp_helper.py`. - Moved `HttpException` class from `cloud/exceptions.py` to `skyvern/exceptions.py`. - Removed `HttpException` class from `cloud/exceptions.py` and added it to `skyvern/exceptions.py`. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cb90067 in 31 seconds
More details
- Looked at
65lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/core/aiohttp_helper.py:38
- Draft comment:
The usage ofHttpExceptionhere is consistent with its definition inskyvern.exceptions. The exception handling and retry logic are well-implemented. - Reason this comment was not posted:
Confidence changes required:0%
TheHttpExceptionclass is defined inskyvern.exceptionsand is imported correctly inaiohttp_helper.py. The usage ofHttpExceptionin line 38 is consistent with its definition, which includes a status code and URL, and optionally a message. The functionaiohttp_get_jsonis designed to make HTTP GET requests and handle exceptions appropriately, including retries and logging. The code structure and logic appear sound, with proper exception handling and use of asynchronous programming withaiohttp.
Workflow ID: wflow_PPSmBsUOkMoyXn3s
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to cb90067 in 48 seconds
More details
- Looked at
66lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_UgeuJtoxZhhOiiYZ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| import aiohttp | ||
| import structlog | ||
|
|
||
| from skyvern.exceptions import HttpException |
There was a problem hiding this comment.
The import statement for HttpException is incorrect. It should be SkyvernHTTPException based on the existing class definitions in skyvern.exceptions. Please update the import and usage accordingly.
Suggested change
| from skyvern.exceptions import HttpException | |
| from skyvern.exceptions import SkyvernHTTPException as HttpException |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrated
aiohttp_helpermodule andHttpExceptionclass fromcloudtoskyvernpackage, updating import paths accordingly.Key points:
aiohttp_helpermodule fromcloudtoskyvernpackage.aiohttp_get_jsonincloud/core/authentication.py,cloud/core/mihomo/mihomo.py,cloud/webeye/proxy.py, andscripts/luca/walmart_client.py.aiohttp_helper.pyfromcloud/core/aiohttp_helper.pytoskyvern/forge/sdk/core/aiohttp_helper.py.HttpExceptionclass fromcloud/exceptions.pytoskyvern/exceptions.py.HttpExceptionclass fromcloud/exceptions.pyand added it toskyvern/exceptions.py.Generated with ❤️ by ellipsis.dev