Implement workflows tab, workflow runs view, ability to run workflows from UI #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit d6fb3b10d334b87412cd692095b339b40e72f982 | |--------|--------| ### Summary: Introduced a new 'Workflows' tab with routing, components, API integrations, pagination, loading states, and added a `FileUpload` component with error handling using a toast notification. **Key points**: - Introduced a new 'Workflows' tab with routing, components, API integrations, pagination, and loading states. - Added `WorkflowsPageLayout`, `Workflows`, and `WorkflowPage` components in `skyvern-frontend/src/routes/workflows/`. - Updated `skyvern-frontend/cloud/router.tsx` and `skyvern-frontend/src/router.tsx` to include new routes for workflows. - Modified `skyvern-frontend/cloud/routes/root/SideNav.tsx` to add a 'Workflows (Beta)' link. - Introduced `FileUpload` component in `skyvern-frontend/src/components/FileUpload.tsx` for handling file inputs with error handling using a toast notification. - Added `Checkbox` component in `skyvern-frontend/src/components/ui/checkbox.tsx`. - Updated `skyvern-frontend/package.json` to include `@radix-ui/react-checkbox` dependency. - Adjusted CSS variables in `skyvern-frontend/cloud/index.css` for better theming. - Enabled Sentry only in production in `skyvern-frontend/cloud/index.tsx`. - Added types for workflow parameters and responses in `skyvern-frontend/src/api/types.ts`. - Implemented pagination and loading states in `skyvern-frontend/src/routes/workflows/WorkflowPage.tsx` and `skyvern-frontend/src/routes/workflows/Workflows.tsx`. - Updated `RunWorkflowForm` in `skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx` to invalidate `workflowRuns` query on success. - Updated `skyvern-frontend/src/routes/workflows/WorkflowRun.tsx` to handle cases where a workflow run does not have any tasks. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit d6fb3b10d334b87412cd692095b339b40e72f982 | |--------|--------| ### Summary: Introduced a new 'Workflows' tab with routing, components, API integrations, pagination, loading states, and added a `FileUpload` component with error handling using a toast notification. **Key points**: - Introduced a new 'Workflows' tab with routing, components, API integrations, pagination, and loading states. - Added `WorkflowsPageLayout`, `Workflows`, and `WorkflowPage` components in `skyvern-frontend/src/routes/workflows/`. - Updated `skyvern-frontend/cloud/router.tsx` and `skyvern-frontend/src/router.tsx` to include new routes for workflows. - Modified `skyvern-frontend/cloud/routes/root/SideNav.tsx` to add a 'Workflows (Beta)' link. - Introduced `FileUpload` component in `skyvern-frontend/src/components/FileUpload.tsx` for handling file inputs with error handling using a toast notification. - Added `Checkbox` component in `skyvern-frontend/src/components/ui/checkbox.tsx`. - Updated `skyvern-frontend/package.json` to include `@radix-ui/react-checkbox` dependency. - Adjusted CSS variables in `skyvern-frontend/cloud/index.css` for better theming. - Enabled Sentry only in production in `skyvern-frontend/cloud/index.tsx`. - Added types for workflow parameters and responses in `skyvern-frontend/src/api/types.ts`. - Implemented pagination and loading states in `skyvern-frontend/src/routes/workflows/WorkflowPage.tsx` and `skyvern-frontend/src/routes/workflows/Workflows.tsx`. - Updated `RunWorkflowForm` in `skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx` to invalidate `workflowRuns` query on success. - Updated `skyvern-frontend/src/routes/workflows/WorkflowRun.tsx` to handle cases where a workflow run does not have any tasks. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit d6fb3b10d334b87412cd692095b339b40e72f982 | |--------|--------| ### Summary: Introduced a new 'Workflows' tab with routing, components, API integrations, pagination, loading states, and added a `FileUpload` component with error handling using a toast notification. **Key points**: - Introduced a new 'Workflows' tab with routing, components, API integrations, pagination, and loading states. - Added `WorkflowsPageLayout`, `Workflows`, and `WorkflowPage` components in `skyvern-frontend/src/routes/workflows/`. - Updated `skyvern-frontend/cloud/router.tsx` and `skyvern-frontend/src/router.tsx` to include new routes for workflows. - Modified `skyvern-frontend/cloud/routes/root/SideNav.tsx` to add a 'Workflows (Beta)' link. - Introduced `FileUpload` component in `skyvern-frontend/src/components/FileUpload.tsx` for handling file inputs with error handling using a toast notification. - Added `Checkbox` component in `skyvern-frontend/src/components/ui/checkbox.tsx`. - Updated `skyvern-frontend/package.json` to include `@radix-ui/react-checkbox` dependency. - Adjusted CSS variables in `skyvern-frontend/cloud/index.css` for better theming. - Enabled Sentry only in production in `skyvern-frontend/cloud/index.tsx`. - Added types for workflow parameters and responses in `skyvern-frontend/src/api/types.ts`. - Implemented pagination and loading states in `skyvern-frontend/src/routes/workflows/WorkflowPage.tsx` and `skyvern-frontend/src/routes/workflows/Workflows.tsx`. - Updated `RunWorkflowForm` in `skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx` to invalidate `workflowRuns` query on success. - Updated `skyvern-frontend/src/routes/workflows/WorkflowRun.tsx` to handle cases where a workflow run does not have any tasks. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to b74f0d1 in 1 minute and 6 seconds
More details
- Looked at
1421lines of code in18files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_eTjWy8OiN0TaHW6H
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| import { useParams } from "react-router-dom"; | ||
| import { RunWorkflowForm } from "./RunWorkflowForm"; | ||
|
|
||
| function defaultValue(type: WorkflowParameterType) { |
There was a problem hiding this comment.
Consider reviewing the default values returned by the defaultValue function for json and file_url types. It might be more appropriate to return an empty object {} or an empty string "" for json, depending on how these values are expected to be used or required by the backend.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b74f0d1 in 1 minute and 7 seconds
More details
- Looked at
1406lines of code in17files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRunParameters.tsx:19
- Draft comment:
Consider changing the default value for JSON type parameters fromnullto an empty object{}or an empty array[]to avoid potential issues in workflows expecting an object or array.
case "json":
return {};
- Reason this comment was not posted:
Confidence of 40% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_hiMug0Ql5lj4BSAa
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b1220b8 in 36 seconds
More details
- Looked at
12lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/package.json:22
- Draft comment:
The addition of@radix-ui/react-checkboxis appropriate for the new Checkbox component functionality. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions the addition of the@radix-ui/react-checkboxdependency, which is confirmed by the diff showing its addition in thepackage.json. This is a standard procedure when new components or functionalities that depend on external libraries are introduced. The version specified (^1.1.1) should be compatible with other@radix-uicomponents used in the project, assuming they follow semantic versioning. This addition seems appropriate and necessary for the new Checkbox component mentioned in the PR description.
Workflow ID: wflow_yD0JsLR5O4bVPfML
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 8152022 in 51 seconds
More details
- Looked at
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pyproject.toml:22
- Draft comment:
The PR description mentions significant changes to the frontend, including new components and routes, but the diff provided only shows a backend dependency update. Please ensure that the correct files are included in the PR for a comprehensive review. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_P0jfRtrgzxiRHapW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduced a new 'Workflows' tab with routing, components, API integrations, pagination, loading states, and a
FileUploadcomponent with error handling using toast notifications.Key points:
WorkflowsPageLayout,Workflows, andWorkflowPagecomponents inskyvern-frontend/src/routes/workflows/.skyvern-frontend/cloud/router.tsxandskyvern-frontend/src/router.tsxto include new routes for workflows.skyvern-frontend/cloud/routes/root/SideNav.tsxto add a 'Workflows (Beta)' link.FileUploadcomponent inskyvern-frontend/src/components/FileUpload.tsxfor handling file inputs with error handling using a toast notification.Checkboxcomponent inskyvern-frontend/src/components/ui/checkbox.tsx.skyvern-frontend/package.jsonto include@radix-ui/react-checkboxdependency.skyvern-frontend/cloud/index.cssfor better theming.skyvern-frontend/cloud/index.tsx.skyvern-frontend/src/api/types.ts.skyvern-frontend/src/routes/workflows/WorkflowPage.tsxandskyvern-frontend/src/routes/workflows/Workflows.tsx.RunWorkflowForminskyvern-frontend/src/routes/workflows/RunWorkflowForm.tsxto invalidateworkflowRunsquery on success.skyvern-frontend/src/routes/workflows/WorkflowRun.tsxto handle cases where a workflow run does not have any tasks.pyproject.tomlto upgradelitellmto version1.41.12.Generated with ❤️ by ellipsis.dev