Fix navigation error in workflow run UI #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit c822822722a7e4b34c71124946f2146cbc1c03db | |--------|--------| ### Summary: Fixes navigation error in `WorkflowRun` component by updating the navigation path in `handleNavigate` function. **Key points**: - Fixes navigation error in `WorkflowRun` component. - Updates `handleNavigate` function in `skyvern-frontend/src/routes/workflows/WorkflowRun.tsx`. - Changes navigation path from `${id}/actions` to `/tasks/${id}/actions`. - Ensures correct navigation to task actions page. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7f6c09e in 25 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:57
- Draft comment:
The change from a relative to an absolute path in the navigation seems appropriate given the context provided in the PR description. This should ensure that navigation is handled correctly regardless of the current URL structure. - Reason this comment was not posted:
Confidence changes required:0%
The PR changes the navigation path in thehandleNavigatefunction from a relative to an absolute path. This change is intended to fix a navigation error by ensuring the correct path is used regardless of the current URL structure. The change from${id}/actionsto/tasks/${id}/actionsmakes sense if the application's routing configuration expects an absolute path starting from the root. This change should correctly direct to the task actions page as described in the PR description.
Workflow ID: wflow_8z0OgclUTH4hBMuy
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7f6c09e in 32 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:57
- Draft comment:
The change from a relative to an absolute path in navigation seems correctly implemented to ensure consistent routing across different parts of the application. - Reason this comment was not posted:
Confidence changes required:0%
The PR changes the navigation path in thehandleNavigatefunction from a relative to an absolute path. This change is consistent across both thenavigatefunction and thewindow.openmethod for new tabs. The PR description indicates that this change is intended to fix a navigation error, likely due to incorrect path resolution from different parts of the application. The use of absolute paths ensures that navigation is consistent regardless of the current route context. The change seems appropriate and correctly implemented based on the provided context.
Workflow ID: wflow_ATlCP9JqsSAZgTu5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes navigation error in
WorkflowRuncomponent by updating the navigation path inhandleNavigatefunction.Key points:
WorkflowRuncomponent.handleNavigatefunction inskyvern-frontend/src/routes/workflows/WorkflowRun.tsx.${id}/actionsto/tasks/${id}/actions.Generated with ❤️ by ellipsis.dev