Implement retry task #600
Implement retry task #600
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 4abb6c2dc803fb970daf0a6be0295ababac89550 | |--------|--------| ### Summary: Added retry functionality for tasks, including a new route, component, and UI updates for retrying tasks in terminal states. **Key points**: - Added `RetryTask` component in `skyvern-frontend/src/routes/tasks/create/retry/RetryTask.tsx`. - Updated `skyvern-frontend/cloud/router.tsx` and `skyvern-frontend/src/router.tsx` to include new route `retry/:taskId`. - Created `taskIsFinalized` function in `skyvern-frontend/src/api/utils.ts` to check if a task is in a terminal state. - Updated `TaskDetails` component in `skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx` to show a retry button for tasks in terminal states. - Added retry option in task actions dropdown in `TaskActions` component in `skyvern-frontend/src/routes/tasks/list/TaskActions.tsx`. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to c4b2ba0 in 41 seconds
More details
- Looked at
165lines of code in5files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_ucpNb1irrli6QgxA
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| import { useTaskQuery } from "../../detail/hooks/useTaskQuery"; | ||
| import { CreateNewTaskForm } from "../CreateNewTaskForm"; | ||
|
|
||
| function RetryTask() { |
There was a problem hiding this comment.
Consider adding a check to ensure the task is in a terminal state before rendering the CreateNewTaskForm. This can prevent users from retrying tasks that should not be retried.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on c4b2ba0 in 49 seconds
More details
- Looked at
164lines of code in5files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_AGSmbN1xtXhj6GZ9
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| import { useTaskQuery } from "../../detail/hooks/useTaskQuery"; | ||
| import { CreateNewTaskForm } from "../CreateNewTaskForm"; | ||
|
|
||
| function RetryTask() { |
There was a problem hiding this comment.
The RetryTask component should verify that the task is in a terminal state before allowing a retry. This is crucial to prevent users from retrying tasks that are not eligible for retry. Consider adding a check using the taskIsFinalized function and handling the case where the task is not finalized appropriately.
Summary:
Added retry functionality for tasks in terminal states, including a new route, component, and UI updates for retrying tasks.
Key points:
RetryTaskcomponent inskyvern-frontend/src/routes/tasks/create/retry/RetryTask.tsx.skyvern-frontend/cloud/router.tsxandskyvern-frontend/src/router.tsxto include new routeretry/:taskId.taskIsFinalizedfunction inskyvern-frontend/src/api/utils.tsto check if a task is in a terminal state.TaskDetailscomponent inskyvern-frontend/src/routes/tasks/detail/TaskDetails.tsxto show a retry button for tasks in terminal states.TaskActionscomponent inskyvern-frontend/src/routes/tasks/list/TaskActions.tsx.Generated with ❤️ by ellipsis.dev