Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Retry Task to Rerun Task #601

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

msalihaltun
Copy link
Collaborator

@msalihaltun msalihaltun commented Jul 12, 2024

🚀 This description was created by Ellipsis for commit 4cc1f4b

Summary:

Change text 'Retry Task' to 'Rerun Task' in TaskDetails.tsx and TaskActions.tsx.

Key points:

  • Change text 'Retry Task' to 'Rerun Task' in skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx.
  • Change text 'Retry Task' to 'Rerun Task' in skyvern-frontend/src/routes/tasks/list/TaskActions.tsx.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 4cc1f4b in 51 seconds

More details
  • Looked at 28 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx:146
  • Draft comment:
    The URL in the Link component still points to /create/retry/${task.task_id}. If the backend route has also been updated to reflect the 'Rerun Task' terminology, this URL should be updated accordingly to maintain consistency.
            <Link to={`/create/rerun/${task.task_id}`}>Rerun Task</Link>
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_2GzXNIMZTlIiTSDK


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -161,7 +161,7 @@ function TaskActions({ task }: Props) {
navigate(`/create/retry/${task.task_id}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navigation URL here still points to /create/retry/${task.task_id}. If the backend route has been updated to use 'rerun' instead of 'retry', this should be updated to maintain consistency.

Suggested change
navigate(`/create/retry/${task.task_id}`);
navigate(`/create/rerun/${task.task_id}`);

@msalihaltun msalihaltun merged commit b52be1a into Skyvern-AI:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant