-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move totp feature to the advanced settings for task #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 8e72e24 in 39 seconds
More details
- Looked at
101
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_lsBNuXIafuFEtLfv
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
8e72e24
to
3133a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 3133a12 in 48 seconds
More details
- Looked at
98
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_oHe3F38bYmHTfbT7
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -20,3 +20,38 @@ Headers: | |||
Body: | |||
.. usual task body .. | |||
``` | |||
|
|||
## Time-based One-time Passowrd (TOTP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'Passowrd' is misspelled in the section title. It should be corrected to 'Password'.
## Time-based One-time Passowrd (TOTP) | |
## Time-based One-time Password (TOTP) |
3133a12
to
10e111f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 10e111f in 43 seconds
More details
- Looked at
98
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_y9wtqK6Kde9oS0J5
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
| task_id | String | yes | tsk_123 | The task ID that needs the verification to be done | | ||
|
||
Response: | ||
| Parameter | Type | Required? | Sample Value | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response table headers for the TOTP endpoint are incorrect and seem to be a copy-paste error from the request table. Please correct the headers to accurately reflect the response parameters.
| Parameter | Type | Required? | Sample Value | Description | | |
| Parameter | Type | Required? | Sample Value | Description | |
Summary:
Moved TOTP feature documentation to
docs/running-tasks/advanced-features.mdx
and updated navigation indocs/mint.json
.Key points:
docs/running-tasks/totp-verification-code.mdx
todocs/running-tasks/advanced-features.mdx
.docs/mint.json
to removerunning-tasks/totp-verification-code
and reflect the new location in the navigation.docs/running-tasks/advanced-features.mdx
.Generated with ❤️ by ellipsis.dev