Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move totp feature to the advanced settings for task #606

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jul 15, 2024

🚀 This description was created by Ellipsis for commit 10e111f

Summary:

Moved TOTP feature documentation to docs/running-tasks/advanced-features.mdx and updated navigation in docs/mint.json.

Key points:

  • Moved TOTP feature documentation from docs/running-tasks/totp-verification-code.mdx to docs/running-tasks/advanced-features.mdx.
  • Updated docs/mint.json to remove running-tasks/totp-verification-code and reflect the new location in the navigation.
  • Added TOTP endpoint setup and validation details to docs/running-tasks/advanced-features.mdx.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 8e72e24 in 39 seconds

More details
  • Looked at 101 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_lsBNuXIafuFEtLfv


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

docs/running-tasks/advanced-features.mdx Outdated Show resolved Hide resolved
@wintonzheng wintonzheng force-pushed the shu/adjust_totp_doc_position branch from 8e72e24 to 3133a12 Compare July 15, 2024 22:00
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 3133a12 in 48 seconds

More details
  • Looked at 98 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_oHe3F38bYmHTfbT7


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -20,3 +20,38 @@ Headers:
Body:
.. usual task body ..
```

## Time-based One-time Passowrd (TOTP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'Passowrd' is misspelled in the section title. It should be corrected to 'Password'.

Suggested change
## Time-based One-time Passowrd (TOTP)
## Time-based One-time Password (TOTP)

@wintonzheng wintonzheng force-pushed the shu/adjust_totp_doc_position branch from 3133a12 to 10e111f Compare July 15, 2024 22:24
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 10e111f in 43 seconds

More details
  • Looked at 98 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_y9wtqK6Kde9oS0J5


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

| task_id | String | yes | tsk_123 | The task ID that needs the verification to be done |

Response:
| Parameter | Type | Required? | Sample Value | Description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response table headers for the TOTP endpoint are incorrect and seem to be a copy-paste error from the request table. Please correct the headers to accurately reflect the response parameters.

Suggested change
| Parameter | Type | Required? | Sample Value | Description |
| Parameter | Type | Required? | Sample Value | Description |

@wintonzheng wintonzheng merged commit c87aedd into main Jul 17, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/adjust_totp_doc_position branch July 17, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant