Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task generation prompt to include completion criteria in navigation goal #611

Conversation

msalihaltun
Copy link
Collaborator

@msalihaltun msalihaltun commented Jul 17, 2024

🚀 This description was created by Ellipsis for commit ed0daf2

Summary:

Updated navigation_goal field in skyvern/forge/prompts/skyvern/generate-task.j2 to require explicit completion criteria.

Key points:

  • Updated skyvern/forge/prompts/skyvern/generate-task.j2.
  • Modified navigation_goal field to require explicit completion criteria.
  • Completion criteria must start with "COMPLETE when...".

Generated with ❤️ by ellipsis.dev

@msalihaltun msalihaltun changed the title Update task generation prompt to include completion criteria Update task generation prompt to include completion criteria in navigation goal Jul 17, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ed0daf2 in 42 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/generate-task.j2:7
  • Draft comment:
    Please provide a description in the PR explaining the rationale behind these changes for better clarity and context.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_cinbJgpWV2Oi46Oz


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 9d106f0 into Skyvern-AI:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant