-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model_info for llm router config #620
Conversation
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit afb421b1830123c03fc5e5c5ee8ecb0ac24826e5 | |--------|--------| ### Summary: Cleaned up GPT-4 routers and added `model_info` field to Azure GPT router configurations. **Key points**: - Removed `get_llm_router_config_for_cloud` function and related configurations from `cloud/__init__.py` and `cloud/llm/router.py`. - Added `model_info` field to `LLMRouterModelConfig` in `skyvern/forge/sdk/api/llm/models.py`. - Updated `get_gpt_turbo_router_config`, `get_llm_router_config_for_gpt4o`, and `get_massive_llm_router_config_for_gpt4o` functions to include `model_info` field. - Removed `ENABLE_AZURE_GPT4V_ROUTER` setting from `cloud/config.py`. - Added `MAX_PARALLEL_REQUESTS` to massive Azure GPT-4O configurations in `cloud/config.py`. - Updated `scripts/run_task.py` to use `get_llm_api_handler_with_router` for `massive-gpt4o` model. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 2141b19 in 23 seconds
More details
- Looked at
19
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/models.py:30
- Draft comment:
The implementation ofmodel_info
withfield(default_factory=dict)
is correct and follows best practices for handling mutable default arguments in dataclasses. - Reason this comment was not posted:
Confidence changes required:0%
The PR adds a new fieldmodel_info
to theLLMRouterModelConfig
class. This field is initialized with a default empty dictionary usingfield(default_factory=dict)
. This is a standard practice for mutable default arguments in dataclasses to avoid shared mutable defaults across instances. The implementation here is correct and follows Python best practices for dataclasses.
Workflow ID: wflow_tJbZj32Aay4plCIj
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 2141b19 in 28 seconds
More details
- Looked at
18
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/models.py:30
- Draft comment:
The implementation ofmodel_info
withfield(default_factory=dict)
is correct and follows best practices for handling mutable default arguments in dataclasses. - Reason this comment was not posted:
Confidence changes required:0%
The PR adds a new fieldmodel_info
to theLLMRouterModelConfig
class. This field is initialized with a default empty dictionary usingfield(default_factory=dict)
. This is a standard practice for mutable default arguments in dataclasses to avoid shared mutable defaults across instances. The implementation here is correct and follows Python best practices for dataclasses.
Workflow ID: wflow_NSDBpwzgDJAnCAdp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary:
Cleaned up GPT-4 routers and added
model_info
field to Azure GPT router configurations.Key points:
get_llm_router_config_for_cloud
fromcloud/__init__.py
andcloud/llm/router.py
.model_info
field toLLMRouterModelConfig
inskyvern/forge/sdk/api/llm/models.py
.get_gpt_turbo_router_config
,get_llm_router_config_for_gpt4o
, andget_massive_llm_router_config_for_gpt4o
to includemodel_info
.ENABLE_AZURE_GPT4V_ROUTER
fromcloud/config.py
.MAX_PARALLEL_REQUESTS
to massive Azure GPT-4O configurations incloud/config.py
.scripts/run_task.py
to useget_llm_api_handler_with_router
formassive-gpt4o
.Generated with ❤️ by ellipsis.dev