Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step output is very noisy as logs and cost us a lot in logging #627

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jul 19, 2024

🚀 This description was created by Ellipsis for commit 3835df6

Summary:

Reduce log verbosity by excluding output field from log comparisons and updates in update_step and handle_completed_step functions in skyvern/forge/agent.py.

Key points:

  • File Modified: skyvern/forge/agent.py
  • Function Modified: update_step
    • Exclude output field from log comparisons and updates.
  • Function Modified: handle_completed_step
    • Remove output field from log updates when marking steps as completed or creating next steps.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3835df6 in 47 seconds

More details
  • Looked at 30 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:1389
  • Draft comment:
    Excluding the 'output' field from logging in update_step might reduce visibility into critical changes. Consider logging outputs conditionally based on a debug or verbose setting to balance between verbosity and necessary insight.
  • Reason this comment was not posted:
    Confidence of 30% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_hWBqD2grNSkKsrKi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Aug 7, 2024

This pull request is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the Stale label Aug 7, 2024
@wintonzheng wintonzheng merged commit 9342dfb into main Aug 9, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/step_output_log_is_noisy branch August 9, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants