Dom tree updates #632
Dom tree updates #632
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ad521b3 in 1.0 minute and 6.404194000000004 seconds
More details
- Looked at
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_qfCd7xFweF3XEC2x
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on ad521b3 in 1.0 minute and 11.098577000000006 seconds
More details
- Looked at
30lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_V0o9zEidm272oOvV
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit c7d4328e9a92d8961e7c45888cd5f6b838433d5c | |--------|--------| ### Summary: Enhanced handling of disabled elements and expanded interactable elements in `skyvern/webeye/scraper/domUtils.js`. **Key points**: - **File Modified**: `skyvern/webeye/scraper/domUtils.js` - **Function Updated**: `isHiddenOrDisabled` - Now checks if `element.disabled` is explicitly defined before evaluating its value. - **Function Updated**: `isInteractable` - Added `a` and `i` tags to the list of elements that can be interactable based on their computed style. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
ykeremy
force-pushed
the
ykeremy/dom-updates
branch
from
ad521b3 to
6bb58e3
Compare
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 6bb58e3 in 1.0 minute and 1.2018369999999976 seconds
More details
- Looked at
24lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_3gobnnOOgmtQZjkl
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const computedStyle = window.getComputedStyle(element); | ||
| const hasPointer = computedStyle.cursor === "pointer"; | ||
| const hasCursor = computedStyle.cursor === "cursor"; | ||
| return hasPointer || hasCursor; | ||
| return hasPointer; |
There was a problem hiding this comment.
The update to isInteractable to include a and i tags only checks for the cursor being 'pointer'. Consider expanding this to check for other interactive attributes or styles, especially for a tags which are often interactable with different cursor styles.
Summary:
Enhanced handling of disabled elements and expanded interactable elements in
skyvern/webeye/scraper/domUtils.js.Key points:
skyvern/webeye/scraper/domUtils.jsisHiddenOrDisabledelement.disabledis explicitly defined before evaluating its value.isInteractableaanditags to the list of elements that can be interactable based on their computed style.Generated with ❤️ by ellipsis.dev