Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shu/making scrolling debug logs #635

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jul 24, 2024

  • make scrolling related logs DEBUG logs
  • make Registering LLM config debug log

🚀 This description was created by Ellipsis for commit fbad122

Summary:

Change log level from info to debug for specific actions in skyvern/forge/sdk/api/llm/config_registry.py and skyvern/webeye/utils/page.py.

Key points:

  • Change log level from info to debug for registering LLM config in skyvern/forge/sdk/api/llm/config_registry.py.
  • Change log level from info to debug for scrolling actions in skyvern/webeye/utils/page.py.
  • Affects register_config method in LLMConfigRegistry class.
  • Affects take_split_screenshots method in SkyvernFrame class.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to fbad122 in 35.222575 seconds

More details
  • Looked at 31 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:35
  • Draft comment:
    The change from INFO to DEBUG log level is appropriate for the context of registering LLM configurations, as it reduces log verbosity while still providing necessary debug information.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR changes the log level from INFO to DEBUG for the log statement in the register_config method of the LLMConfigRegistry class. This change is consistent with the PR description, which aims to make certain logs less verbose by changing them to DEBUG level. The change is straightforward and does not introduce any new issues or bugs. The use of llm_key as a parameter in the log message provides useful context for debugging without being overly verbose.
2. skyvern/webeye/utils/page.py:94
  • Draft comment:
    Changing the log level from INFO to DEBUG for scrolling-related logs is appropriate as it reduces unnecessary verbosity in production logs while retaining useful debug information.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR changes the log level from INFO to DEBUG for the log statements related to scrolling actions in the take_split_screenshots method of the SkyvernFrame class. This change aligns with the PR description's intent to make scrolling-related logs less verbose by changing them to DEBUG level. The log statements provide context about the scrolling actions, such as the URL being scrolled, the number of screenshots taken, and the scroll positions before and after scrolling. These details are useful for debugging but do not need to be at the INFO level during normal operations.

Workflow ID: wflow_IajKT8wrZ04Osi9U


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit c52f8f2 into main Jul 25, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/making_scrolling_debug_logs branch July 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant