Use trimmed element tree for info extraction #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit e55da266047d517fdc758959e16b60c2e0618262 | |--------|--------| ### Summary: Updated `extract_information_for_navigation_goal` in `skyvern/webeye/actions/handler.py` to use a trimmed element tree for information extraction. **Key points**: - Updated `skyvern/webeye/actions/handler.py` to use a trimmed element tree for information extraction. - Imported `ElementTreeFormat` from `skyvern/webeye/scraper/scraper`. - Modified `extract_information_for_navigation_goal` to build the element tree using `ElementTreeFormat.HTML`. - Logged the element tree building process with task and workflow run IDs. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit e55da266047d517fdc758959e16b60c2e0618262 | |--------|--------| ### Summary: Updated `extract_information_for_navigation_goal` in `skyvern/webeye/actions/handler.py` to use a trimmed element tree for information extraction. **Key points**: - Updated `skyvern/webeye/actions/handler.py` to use a trimmed element tree for information extraction. - Imported `ElementTreeFormat` from `skyvern/webeye/scraper/scraper`. - Modified `extract_information_for_navigation_goal` to build the element tree using `ElementTreeFormat.HTML`. - Logged the element tree building process with task and workflow run IDs. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit e55da266047d517fdc758959e16b60c2e0618262 | |--------|--------| ### Summary: Updated `extract_information_for_navigation_goal` in `skyvern/webeye/actions/handler.py` to use a trimmed element tree for information extraction. **Key points**: - Updated `skyvern/webeye/actions/handler.py` to use a trimmed element tree for information extraction. - Imported `ElementTreeFormat` from `skyvern/webeye/scraper/scraper`. - Modified `extract_information_for_navigation_goal` to build the element tree using `ElementTreeFormat.HTML`. - Logged the element tree building process with task and workflow run IDs. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
|
Skipped PR review on afe3c23 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away. Generated with ❤️ by ellipsis.dev |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to afe3c23 in 46.548823 seconds
More details
- Looked at
52lines of code in2files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:1060
- Draft comment:
Ensure that the use ofElementTreeFormat.HTMLdoes not negatively impact the accuracy of data extraction. Consider adding tests to verify that the trimmed element tree still captures all necessary data for accurate extraction. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_tnDoHP44daZ1LABl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updated
extract_information_for_navigation_goalinskyvern/webeye/actions/handler.pyto use a trimmed element tree for information extraction.Key points:
skyvern/webeye/actions/handler.pyto use a trimmed element tree for information extraction.ElementTreeFormatfromskyvern/webeye/scraper/scraper.extract_information_for_navigation_goalto build the element tree usingElementTreeFormat.HTML.Generated with ❤️ by ellipsis.dev